Code review comment for lp:~nskaggs/autopilot/catch-stateerror-printtree

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

I doubt that turning this:

for p in sorted(self.get_properties()):

into this:

for prop, value in sorted(self.get_properties().items()):

Is the cause of your problems. You're correct though - we need a better way to create fake proxy objects. This is something I've been thinking about for a looong time.

I suggest that you merge in my branch, which already has many of the changes in here, and add your exception handling and test code.

« Back to merge proposal