Code review comment for lp:~nschloe/dolfin/exodus
Revision history for this message
| Anders Logg (logg) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On Mon, Mar 11, 2013 at 12:52:24PM -0000, Nico Schlömer wrote:
> Exodus file writing is only activated if the system VTK has Exodus support. There's some CMake logic to check for it, and I just added a status message if it's not found (which may be the case on your system). With the default Ubuntu VTK, for example, it does work.
> If you want to try it out again, you should either see a configure time status message about missing Exodus or it should work.
The unit test should work regardless of whether VTK has Exodus
support.
I suggest adding:
1. a runtime error (dolfin_error) if VTK Exodus is missing (in
File.cpp) instead of just missing file format
2. a runtime check in the unit test so that it is skipped if the VTK
Exodus format is missing
--
Anders