Code review comment for lp:~notnownikki/jenkins-launchpad-plugin/touch-image-builder

Do you mean, move those variable init lines to ubuntu-touch-image-setup.sh
and have build-android.sh fail if they're not set, or check for them
in ubuntu-touch-image-setup.sh and have ubuntu-touch-image-setup.sh fail if
they're not set?

On Thu, Feb 13, 2014 at 4:11 PM, Francis Ginther <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> Please add some variable initialization to ubuntu-touch-image-setup.sh,
> (or better yet, source a common file with the variable init done only once)
> this could be executed prior to build-android.sh and would fail if the
> environment wasn't already setup.
>
> BUILD_DEVICE_TARGETS=${BUILD_DEVICE_TARGETS:-"manta maguro mako grouper"}
> BUILD_VENDOR_TARGETS=${BUILD_VENDOR_TARGETS:-"samsung lge audience
> broadcom nxp nvidia invensense elan widevine asus"}
> --
>
> https://code.launchpad.net/~mike-powerthroughwords/jenkins-launchpad-plugin/touch-image-builder/+merge/206204
> You are the owner of
> lp:~mike-powerthroughwords/jenkins-launchpad-plugin/touch-image-builder.
>