Merge lp:~notabilis27/widelands/bug-tab-crash into lp:widelands

[Notabilis]

[TiborB (tiborb95)]

Tested, the crash is gone.

[SirVer (sirver)]

lgtm. Thank you!

I just realized that you are not yet mentioned in data/txts/developers.json. Could you add yourself as last entry in members and merge this?

review: Approve

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 1179. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/143755481.
Appveyor build 1017. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_notabilis27_widelands_bug_tab_crash-1017.

[Notabilis (notabilis27)]

Assuming that you mean me: Adding myself to the list is no problem.
But I am not sure what you mean with "merge". Add the change to this branch? Create a new branch and merge with this one? Merge this one into trunk?
The last one I can't do as far as I know and the second one seems strange to me. However the first one is without any merge, so I am probably missing something.

[SirVer (sirver)]

I am sorry that I was unclear. I should have explained more carefully, but had little time.

It is true that you cannot merge yourself into trunk. But everybody can instruct bunnybot to do so - and bunnybot should really be the only committer to trunk besides other bots. Bunnybot has no ACLs because they were never necessary - noybody ever tried to sneak code in that was not agreed on being a good idea.

So what I meant was: add yourself to the list of devs in this branch, and then merge yourself by instructing bunnybot to do so. You can do that by replying here and including in your reply on a line of its own "@bunnybot merge".

[Notabilis (notabilis27)]

Thanks for the explanation, is done now.

@bunnybot merge

=== modified file 'data/txts/developers.json'
--- data/txts/developers.json	2016-04-29 06:38:10 +0000
+++ data/txts/developers.json	2016-07-13 05:50:36 +0000
@@ -107,7 +107,8 @@
 						"Miroslav Remák (MiroslavR)",
 						"Janosch Peters",
 						"Hasi50 (Klaus Halfmann)",
-						"Philipp Klaus Krause (PkK)"
+						"Philipp Klaus Krause (PkK)",
+						"Notabilis"
 					]
 				}
 			]

=== modified file 'src/ui_basic/panel.cc'
--- src/ui_basic/panel.cc	2016-07-11 16:54:52 +0000
+++ src/ui_basic/panel.cc	2016-07-13 05:50:36 +0000
@@ -550,6 +550,10 @@
 	if (down) {
 		if (focus_) {
 				Panel * p = focus_->next_;
+				if (focus_ == last_child_) {
+					p = first_child_;
+				}
+
 				switch (code.sym) {
 
 				case SDLK_TAB: