Ubuntu
xfce4-power-manager package

Code review comment for lp:~noskcaj/ubuntu/trusty/xfce4-power-manager/dimming

  1. Trusty (14.04)
  2. dimming
  3. Merge into trusty
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Uploaded, thanks for your work. Some notes:

- You are doing something weird with the bzr branch (like removing and then re-adding .pc directory), that makes it harder to review.
- In DEP-3 patches, we prefer short bug URLs (like https://bugs.launchpad.net/bugs/1234567).
- Patch descriptions work like Description: field in debian/control, so should start with lowercase (and not end with a period).

review: Approve

« Back to merge proposal