Merge lp:~noskcaj/ubuntu/trusty/libdvdnav/ppc64el into lp:ubuntu/trusty/libdvdnav

Proposed by Jackson Doak
Status: Rejected
Rejected by: Michael Terry
Proposed branch: lp:~noskcaj/ubuntu/trusty/libdvdnav/ppc64el
Merge into: lp:ubuntu/trusty/libdvdnav
Diff against target: 43 lines (+10/-3)
3 files modified
debian/changelog (+6/-0)
debian/control (+3/-2)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/trusty/libdvdnav/ppc64el
Reviewer Review Type Date Requested Status
Michael Terry Disapprove
Review via email: mp+200268@code.launchpad.net

Description of the change

Build with autoreconf

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work, do you still need the autotools-dev Build-Depends if you use dh-autoreconf instead?

Revision history for this message
Jackson Doak (noskcaj) wrote :

Probably not, but is it really something to block the merge?

On Fri, Jan 10, 2014 at 8:40 PM, Sebastien Bacher <email address hidden> wrote:

> Thanks for the work, do you still need the autotools-dev Build-Depends if
> you use dh-autoreconf instead?
> --
>
> https://code.launchpad.net/~noskcaj/ubuntu/trusty/libdvdnav/ppc64el/+merge/200268
> You are the owner of lp:~noskcaj/ubuntu/trusty/libdvdnav/ppc64el.
>

Revision history for this message
Michael Terry (mterry) wrote :

Debian updated and fixed this for us. Thanks anyway, Jackson!

review: Disapprove

Unmerged revisions

22. By Jackson Doak

Use autoreconf instead of autotools-dev to fix ppc64el ftbfs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-11-25 19:17:09 +0000
3+++ debian/changelog 2014-01-02 01:47:54 +0000
4@@ -1,3 +1,9 @@
5+libdvdnav (4.2.0+20130225-4ubuntu1) trusty; urgency=medium
6+
7+ * Use autoreconf instead of autotools-dev to fix ppc64el ftbfs
8+
9+ -- Jackson Doak <noskcaj@ubuntu.com> Thu, 02 Jan 2014 12:26:13 +1100
10+
11 libdvdnav (4.2.0+20130225-4) unstable; urgency=low
12
13 * Adopting Package, Closes: #712111
14
15=== modified file 'debian/control'
16--- debian/control 2013-11-25 19:17:09 +0000
17+++ debian/control 2014-01-02 01:47:54 +0000
18@@ -1,9 +1,10 @@
19 Source: libdvdnav
20 Section: libs
21 Priority: optional
22-Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
25 Uploaders: Reinhard Tartler <siretart@tauware.de>, Benjamin Drung <bdrung@debian.org>, Matteo F. Vescovi <mfv.debian@gmail.com>
26-Build-Depends: debhelper (>= 9), autotools-dev, doxygen, libdvdread-dev
27+Build-Depends: debhelper (>= 9), autotools-dev, doxygen, libdvdread-dev, dh-autoreconf
28 Standards-Version: 3.9.4
29 Homepage: http://github.com/microe/libdvdnav
30
31
32=== modified file 'debian/rules'
33--- debian/rules 2013-03-13 19:12:18 +0000
34+++ debian/rules 2014-01-02 01:47:54 +0000
35@@ -5,7 +5,7 @@
36 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
37
38 %:
39- dh ${@} --with autotools_dev
40+ dh ${@} --with autoreconf
41
42 override_dh_auto_clean:
43 [ ! -f config.mak ] || $(MAKE) distclean

Subscribers

People subscribed via source and target branches

to all changes: