Merge lp:~noskcaj/ubuntu/trusty/juman/ftbfs into lp:ubuntu/trusty/juman

Proposed by Jackson Doak
Status: Needs review
Proposed branch: lp:~noskcaj/ubuntu/trusty/juman/ftbfs
Merge into: lp:ubuntu/trusty/juman
Diff against target: 171 lines (+67/-23)
6 files modified
debian/README.Debian (+4/-2)
debian/changelog (+18/-9)
debian/control (+10/-2)
debian/juman-dic.install (+3/-0)
debian/juman-server (+12/-0)
debian/rules (+20/-10)
To merge this branch: bzr merge lp:~noskcaj/ubuntu/trusty/juman/ftbfs
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+208298@code.launchpad.net

Description of the change

Might fix the ftbfs. I couldn't reproduce the ftbfs locally, but this is the fix recommended in the debian RC bug. Builds fine locally and in ppa.

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

+Package: libjuman-perl
+Architecture: all
+Depends: ${perl:Depends}, juman
+Description: Perl binding of JUMAN
+ This package provides Perl binding of Juman, that is a Japanese
+ morphological analysis system.

I think we should not add new binary packages after feature freeze. Is there any real need for that?

Revision history for this message
Jackson Doak (noskcaj) wrote :

I don't know if it's good to add this later, but it's been in proposed for some time

Revision history for this message
Iain Lane (laney) wrote :

You can reproduce the ftbfs by building an arch-only build (not indep packages). Building on i386 and nowhere else is a hint to that.

review: Approve

Unmerged revisions

9. By Jackson Doak

update maintainer

8. By Jackson Doak

Replace cp commands in d/rules with d/juman-doc.insall

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/README.Debian'
--- debian/README.Debian 2004-04-03 23:47:16 +0000
+++ debian/README.Debian 2014-02-26 08:35:23 +0000
@@ -7,7 +7,9 @@
7information (pronunciation, semantic information, etc).7information (pronunciation, semantic information, etc).
88
9Note: Juman can not process strings encoded in other coding systems9Note: Juman can not process strings encoded in other coding systems
10than EUC-JP, and also its outputs are encoded in EUC-JP.10than UTF-8, and also its outputs are encoded in UTF-8. This is a big
11difference between the current version of Juman and the older
12versions.
1113
12If you want to use Juman server, try these steps.14If you want to use Juman server, try these steps.
1315
@@ -16,4 +18,4 @@
16 update-rc.d juman-server defaults 99 118 update-rc.d juman-server defaults 99 1
17 /etc/init.t/juman-server start19 /etc/init.t/juman-server start
1820
19 -- TSUCHIYA Masatoshi <tsuchiya@namazu.org>, Fri Feb 20 14:24:18 200421 -- TSUCHIYA Masatoshi <tsuchiya@namazu.org>, Wed, 25 Jan 2012 21:05:33 +0900
2022
=== modified file 'debian/changelog'
--- debian/changelog 2012-10-07 17:05:06 +0000
+++ debian/changelog 2014-02-26 08:35:23 +0000
@@ -1,12 +1,21 @@
1juman (7.0-1.1) unstable; urgency=low1juman (7.0-3ubuntu1) trusty; urgency=medium
22
3 * Non-maintainer upload.3 * Replace cp commands in d/rules with d/juman-doc.insall
44
5 [ Konstantinos Margaritis ]5 -- Jackson Doak <noskcaj@ubuntu.com> Wed, 26 Feb 2014 19:18:25 +1100
6 * Create usr/share/doc/juman link in binary-arch build6
7 This should fix the FTBFS reported for non i386 arches. Closes: #6576887juman (7.0-3) unstable; urgency=low
88
9 -- Christian Perrier <bubulle@debian.org> Sun, 07 Oct 2012 17:05:06 +02009 * Call dh with "--with autotools_dev" option (closes: #727909).
10 * Build depends to autotools-dev.
11
12 -- TSUCHIYA Masatoshi <tsuchiya@namazu.org> Wed, 30 Oct 2013 22:28:48 +0900
13
14juman (7.0-2) unstable; urgency=low
15
16 * Add libjuman-perl.
17
18 -- TSUCHIYA Masatoshi <tsuchiya@namazu.org> Mon, 23 Jan 2012 22:23:49 +0900
1019
11juman (7.0-1) unstable; urgency=low20juman (7.0-1) unstable; urgency=low
1221
1322
=== modified file 'debian/control'
--- debian/control 2012-01-20 12:13:19 +0000
+++ debian/control 2014-02-26 08:35:23 +0000
@@ -1,8 +1,9 @@
1Source: juman1Source: juman
2Section: misc2Section: misc
3Priority: optional3Priority: optional
4Maintainer: TSUCHIYA Masatoshi <tsuchiya@namazu.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5Build-Depends: debhelper (>= 7), quilt5XSBC-Original-Maintainer: TSUCHIYA Masatoshi <tsuchiya@namazu.org>
6Build-Depends: debhelper (>= 7), quilt, autotools-dev
6Standards-Version: 3.9.27Standards-Version: 3.9.2
78
8Package: juman9Package: juman
@@ -40,3 +41,10 @@
40Description: Library of JUMAN41Description: Library of JUMAN
41 This package provides runtime libraries of Juman, that is a Japanese42 This package provides runtime libraries of Juman, that is a Japanese
42 morphological analysis system.43 morphological analysis system.
44
45Package: libjuman-perl
46Architecture: all
47Depends: ${perl:Depends}, juman
48Description: Perl binding of JUMAN
49 This package provides Perl binding of Juman, that is a Japanese
50 morphological analysis system.
4351
=== added file 'debian/juman-dic.install'
--- debian/juman-dic.install 1970-01-01 00:00:00 +0000
+++ debian/juman-dic.install 2014-02-26 08:35:23 +0000
@@ -0,0 +1,3 @@
1dic/*.dic usr/share/juman/dic
2autodic/*.dic usr/share/juman/autodic
3wikipediadic/*.dic usr/share/juman/wikipediadic
0\ No newline at end of file4\ No newline at end of file
15
=== modified file 'debian/juman-server'
--- debian/juman-server 2012-01-20 12:13:19 +0000
+++ debian/juman-server 2014-02-26 08:35:23 +0000
@@ -4,6 +4,18 @@
4# and call update-rc.d to install the links of the copied script.4# and call update-rc.d to install the links of the copied script.
5#5#
66
7### BEGIN INIT INFO
8# Provides: juman
9# Required-Start: $local_fs $network $syslog
10# Required-Stop: $local_fs $network $syslog
11# Should-Start:
12# Should-Stop:
13# Default-Start: 2 3 4 5
14# Default-Stop: 0 1 6
15# Short-Description: Juman init script
16# Description: Init script for Juman server
17### END INIT INFO
18
7NAME=juman19NAME=juman
8DAEMON="/usr/bin/$NAME"20DAEMON="/usr/bin/$NAME"
9DESC="Juman server"21DESC="Juman server"
1022
=== modified file 'debian/rules'
--- debian/rules 2012-10-07 17:05:06 +0000
+++ debian/rules 2014-02-26 08:35:23 +0000
@@ -4,22 +4,30 @@
4# Uncomment this to turn on verbose mode.4# Uncomment this to turn on verbose mode.
5#export DH_VERBOSE=15#export DH_VERBOSE=1
66
7ifndef PERL
8PERL = /usr/bin/perl
9endif
10PERL_OPTIMIZE = -O2 -Wall
11ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
12PERL_OPTIMIZE += -g
13endif
14
7%:15%:
8 dh $@ --with quilt16 dh $@ --with quilt --with autotools_dev
917
10override_dh_auto_configure:18override_dh_auto_configure:
11 dh_auto_configure -- --libexecdir=/usr/lib --datadir=/usr/lib19 dh_auto_configure -- --libexecdir=/usr/lib --datadir=/usr/lib
1220 cd perl && $(PERL) Makefile.PL INSTALLDIRS=vendor
13override_dh_auto_install-arch:21
22override_dh_auto_build:
23 dh_auto_build
24 $(MAKE) -C perl OPTIMIZE="$(PERL_OPTIMIZE)" DICDIR=`pwd`/dic
25
26dicprefix=debian/juman-dic/usr/share/juman
27override_dh_auto_install:
14 dh_auto_install28 dh_auto_install
15
16dicprefix=debian/juman-dic/usr/share/juman
17override_dh_auto_install-indep:
18 rm -rf debian/tmp/usr/lib/juman/doc29 rm -rf debian/tmp/usr/lib/juman/doc
19 dh_link -pjuman usr/share/doc/juman usr/lib/juman/doc30 dh_link -pjuman usr/share/doc/juman usr/lib/juman/doc
20 cp -p dic/*.dic $(dicprefix)/dic
21 cp -p autodic/*.dic $(dicprefix)/autodic
22 cp -p wikipediadic/*.dic $(dicprefix)/wikipediadic
23 for d in dic autodic wikipediadic ; do \31 for d in dic autodic wikipediadic ; do \
24 for f in $(dicprefix)/$${d}/* ; do \32 for f in $(dicprefix)/$${d}/* ; do \
25 dh_link -pjuman-dic \33 dh_link -pjuman-dic \
@@ -27,10 +35,12 @@
27 `echo $$f|sed s,debian/juman-dic/usr/share/,usr/lib/,` ;\35 `echo $$f|sed s,debian/juman-dic/usr/share/,usr/lib/,` ;\
28 done ;\36 done ;\
29 done37 done
38 $(MAKE) -C perl install PREFIX=`pwd`/debian/libjuman-perl/usr DICDIR=`pwd`/dic
3039
31override_dh_auto_clean:40override_dh_auto_clean:
32 dh_auto_clean41 dh_auto_clean
33 -rm -f dic/*.int dic/jumandic.*42 -$(MAKE) -C perl realclean
43 -rm -f dic/*.int dic/jumandic.* dic/JUMAN.connect
34 -rm -f autodic/*.int autodic/jumandic.*44 -rm -f autodic/*.int autodic/jumandic.*
35 -rm -f wikipediadic/*.int wikipediadic/jumandic.* 45 -rm -f wikipediadic/*.int wikipediadic/jumandic.*
3646

Subscribers

People subscribed via source and target branches

to all changes: