Juju Charms Collection
nova-cloud-controller package

Code review comment for lp:~nobuto/charms/trusty/nova-cloud-controller/fix-catch-error

  1. Trusty Tahr (14.04)
  2. fix-catch-error
  3. Merge into next
Revision history for this message
Felipe Reyes (freyes) wrote :

Hi Nobuto,

Thanks for your MP, this looks good to me and the unit tests run OK, and effectively the exception that should be catched in py2.x is OSError[0]. I wonder what I was thinking when I wrote IOError :\

Amulet tests failed, I'll ask beisner to rerun this MP, there is no way this change break them.

Best,

[0] >>> os.remove('/tmp/asdfg')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: [Errno 2] No such file or directory: '/tmp/asdfg'

« Back to merge proposal