Merge lp:~nobuto/charms/precise/mysql/no-ppa into lp:charms/mysql
Proposed by
Nobuto Murata
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Clint Byrum | ||||
Approved revision: | 82 | ||||
Merged at revision: | 81 | ||||
Proposed branch: | lp:~nobuto/charms/precise/mysql/no-ppa | ||||
Merge into: | lp:charms/mysql | ||||
Diff against target: |
17 lines (+1/-2) 2 files modified
hooks/install (+0/-1) revision (+1/-1) |
||||
To merge this branch: | bzr merge lp:~nobuto/charms/precise/mysql/no-ppa | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Clint Byrum (community) | Approve | ||
Review via email:
|
Description of the change
mysql charm adds PPA by default. but it's not needed for precise or later releases.
In this branch, add PPA only if releases are older than precise.
To post a comment you must log in.
Hi Nobuto, thanks for the change!
Since this branch is precise and later only (it won't be used on oneiric or natty), we can just remove the conditional logic and remove all of that code, no need to test w/ lsb_release.
Please change back to 'Needs Review' after you have fixed that.