Merge lp:~nobuto/charms/precise/mysql/no-ppa into lp:charms/mysql

Proposed by Nobuto Murata
Status: Merged
Approved by: Clint Byrum
Approved revision: 82
Merged at revision: 81
Proposed branch: lp:~nobuto/charms/precise/mysql/no-ppa
Merge into: lp:charms/mysql
Diff against target: 17 lines (+1/-2)
2 files modified
hooks/install (+0/-1)
revision (+1/-1)
To merge this branch: bzr merge lp:~nobuto/charms/precise/mysql/no-ppa
Reviewer Review Type Date Requested Status
Clint Byrum (community) Approve
Review via email: mp+121520@code.launchpad.net

Description of the change

mysql charm adds PPA by default. but it's not needed for precise or later releases.

In this branch, add PPA only if releases are older than precise.

To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi Nobuto, thanks for the change!

Since this branch is precise and later only (it won't be used on oneiric or natty), we can just remove the conditional logic and remove all of that code, no need to test w/ lsb_release.

Please change back to 'Needs Review' after you have fixed that.

review: Needs Fixing
Revision history for this message
Nobuto Murata (nobuto) wrote :

Hi Clint,

I have fixed my branch. Thanks!

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Awesome! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/install'
2--- hooks/install 2012-08-22 18:54:37 +0000
3+++ hooks/install 2012-09-06 00:46:19 +0000
4@@ -1,6 +1,5 @@
5 #!/bin/bash
6
7-add-apt-repository -y ppa:charmers/charm-helpers
8 apt-get update
9 apt-get install -y debconf-utils python-mysqldb uuid augeas-tools augeas-lenses pwgen dnsutils charm-helper-sh || exit 1
10
11
12=== modified file 'revision'
13--- revision 2012-08-22 18:48:34 +0000
14+++ revision 2012-09-06 00:46:19 +0000
15@@ -1,1 +1,1 @@
16-148
17+149

Subscribers

People subscribed via source and target branches