Code review comment for lp:~nobuto/charm-helpers/execd

Revision history for this message
Stuart Bishop (stub) wrote :

execd_run() is doing "subprocess.check_output(submodule_path, stderr=stderr)", which returns a byte string rather than text. Change that to "subprocess.check_output(submodule_path, stderr=stderr, universal_newlines=True)" or similar to have it return the output as a standard text string (unicode).

« Back to merge proposal