Reflected review comments, but I found the test is failing with Python 3. I don't know how to handle this, but will look into it.
====================================================================== FAIL: tests.payload.test_execd.ExecDTestCase.test_execd_run_logs_exception ---------------------------------------------------------------------- testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/nobuto/dev/charm-helpers_execd/.venv3/lib/python3.5/site-packages/mock.py", line 1201, in patched return func(*args, **keywargs) File "/home/nobuto/dev/charm-helpers_execd/tests/payload/test_execd.py", line 142, in test_execd_run_logs_exception log_.assert_called_with(expected_log) File "/home/nobuto/dev/charm-helpers_execd/.venv3/lib/python3.5/site-packages/mock.py", line 835, in assert_called_with raise AssertionError(msg) AssertionError: Expected call: log('Error (1) running /tmp/tmp11nk64mu/exec.d/basenode/charm-pre-install. Output: stdout_from_pre_install\nstderr_from_pre_install\n') Actual call: log("Error (1) running /tmp/tmp11nk64mu/exec.d/basenode/charm-pre-install. Output: b'stdout_from_pre_install\\nstderr_from_pre_install\\n'")
« Back to merge proposal
Reflected review comments, but I found the test is failing with Python 3. I don't know how to handle this, but will look into it.
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= test_execd. ExecDTestCase. test_execd_ run_logs_ exception ------- ------- ------- ------- ------- ------- ------- ------- ------- testresult. real._StringExc eption: Traceback (most recent call last): nobuto/ dev/charm- helpers_ execd/. venv3/lib/ python3. 5/site- packages/ mock.py" , line 1201, in patched nobuto/ dev/charm- helpers_ execd/tests/ payload/ test_execd. py", line 142, in test_execd_ run_logs_ exception .assert_ called_ with(expected_ log) nobuto/ dev/charm- helpers_ execd/. venv3/lib/ python3. 5/site- packages/ mock.py" , line 835, in assert_called_with u/exec. d/basenode/ charm-pre- install. Output: stdout_ from_pre_ install\ nstderr_ from_pre_ install\ n') u/exec. d/basenode/ charm-pre- install. Output: b'stdout_ from_pre_ install\ \nstderr_ from_pre_ install\ \n'")
FAIL: tests.payload.
-------
testtools.
File "/home/
return func(*args, **keywargs)
File "/home/
log_
File "/home/
raise AssertionError(msg)
AssertionError: Expected call: log('Error (1) running /tmp/tmp11nk64m
Actual call: log("Error (1) running /tmp/tmp11nk64m