GTG

Merge lp:~nmu-sscheel/gtg/fix-open-link-while-selecting into lp:~gtg/gtg/old-trunk

Proposed by Steve Scheel
Status: Merged
Merged at revision: 1135
Proposed branch: lp:~nmu-sscheel/gtg/fix-open-link-while-selecting
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 35 lines (+7/-1) (has conflicts)
3 files modified
AUTHORS (+4/-0)
CHANGELOG (+2/-0)
GTG/gtk/editor/taskview.py (+1/-1)
Text conflict in AUTHORS
To merge this branch: bzr merge lp:~nmu-sscheel/gtg/fix-open-link-while-selecting
Reviewer Review Type Date Requested Status
Izidor Matušov running, code Approve
Review via email: mp+99434@code.launchpad.net

Description of the change

I added to the conditionals when the link is to clicked to check and make sure that the link isn't currently selected for copying/pasting/etc. This stops it from opening a link if a user releases on the link while selecting the link, but they will need to double click on the link if there is a piece of the link selected in order to open it.

To post a comment you must log in.
Revision history for this message
Izidor Matušov (izidor) wrote :

Awesome, it fixes the problem! No more annoying opened webpages when selecting a link! Thank you

review: Approve (running, code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'AUTHORS'
--- AUTHORS 2012-03-26 22:18:17 +0000
+++ AUTHORS 2012-03-26 22:20:29 +0000
@@ -98,4 +98,8 @@
98* huxuan <i@huxuan.org>98* huxuan <i@huxuan.org>
99* Nimit Shah <nimit.svnit@gmail.com>99* Nimit Shah <nimit.svnit@gmail.com>
100* Abdul Rauf <abdulraufhaseeb@gmail.com>100* Abdul Rauf <abdulraufhaseeb@gmail.com>
101<<<<<<< TREE
101* Radina Matic <radina.matic@gmail.com>102* Radina Matic <radina.matic@gmail.com>
103=======
104* Steve Scheel <nmu.sscheel@gmail.com>
105>>>>>>> MERGE-SOURCE
102106
=== modified file 'CHANGELOG'
--- CHANGELOG 2012-03-22 13:50:35 +0000
+++ CHANGELOG 2012-03-26 22:20:29 +0000
@@ -1,3 +1,5 @@
12012-03-26
2 * Stopped links from opening when accidently letting go of mouse button while selecting them
12012-0?-?? Getting Things GNOME! 0.332012-0?-?? Getting Things GNOME! 0.3
2 * Hide tasks with due date someday, #9313764 * Hide tasks with due date someday, #931376
3 * New Date class by Paul Kishimoto and Izidor Matušov5 * New Date class by Paul Kishimoto and Izidor Matušov
46
=== modified file 'GTG/gtk/editor/taskview.py'
--- GTG/gtk/editor/taskview.py 2012-03-22 13:32:49 +0000
+++ GTG/gtk/editor/taskview.py 2012-03-26 22:20:29 +0000
@@ -1330,7 +1330,7 @@
1330 if typ == "subtask":1330 if typ == "subtask":
1331 self.open_task(anchor)1331 self.open_task(anchor)
1332 elif typ == "http":1332 elif typ == "http":
1333 if button == 1 and self.check_link(anchor):1333 if button == 1 and self.check_link(anchor) and self.buff.get_has_selection() == False:
1334 openurl(anchor)1334 openurl(anchor)
1335 else:1335 else:
1336 print "Unknown link type for %s" %anchor1336 print "Unknown link type for %s" %anchor

Subscribers

People subscribed via source and target branches

to status/vote changes: