Code review comment for lp:~nmb/bzr-keywords/after-2.6

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

On Fri, Jul 20, 2012 at 01:16:18PM -0000, Neil Martinsen-Burrell wrote:
> Yes, r20 of bzr-keywords broke compatibility with versions of bzr that
> don't have r6498.5.1 (merged in r6517):

> nmb@garble[~/src/bzr/bzr.all]$ bzr revert -r tag:bzr-2.5.1
> [...]
> nmb@garble[~/src/bzr/bzr.all]$ ./bzr selftest -s bp.keywords
> 'module' object has no attribute 'filter_stacks_registry'
> ----------------------------------------------------------------------
> Ran 0 tests in 0.000s

> OK

> This came up on the mailing list recently and reverting to r19 fixed
> the problem on bzr 2.5.0.
Ah - thanks.

I've pushed a fix to fall back to the old registration function if the
new one isn't available.

Cheers,

jelmer

« Back to merge proposal