Code review comment for lp:~nmb/bzr-explorer/quote-commands-osx

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Thanks for the patch. It's not quite ready to land though ...

1. This breaks backwards compatibility for anyone who has configured editors previously. At a minimum, please update NEWS with an item in a section called "Compatibility breaks" (which should go first in the list of sections).

2. The comments and settings in skin/editors.conf need updating as well, e.g. Gimp.app -> /Applications/Gimp.app.

Alternatively, maybe introduce a method called appname_to_path() and let it decide whether to return /Applications/%s or "/Applications/%s", depending on whether appname has a space or not.

review: Needs Fixing

« Back to merge proposal