Code review comment for lp:~njpatel/unity/nicer-glib-signals

Revision history for this message
Tim Penhey (thumper) wrote :

Hi Neil,

After several hours of fluffing around trying to get a nicer Add method, I've
given up as well. It seems that the sigc wrappers don't give us access to the
type information for the function call arguments. We could perhaps submit a
patch to the sigc guys, but not with this branch.

I forgot that the shared_ptr has an explicit constructor, so passing through
the shared pointer would be a bit cumbersome as you mention. So lets not
worry about that here.

By having UnityCore/UnityCore.h we are pulling in headers that we don't care
about, and creating an artificial dependency between our code and other
headers that have no impact on the code in the source file. This increases
coupling between the files and increases compilation time.

review: Approve

« Back to merge proposal