Code review comment for lp:~nikwen/webbrowser-app/open-in-new-background-tab

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Yes, it could be made a boolean but that would also alter its current behaviour.

The way it's currently implemented allows to disable the entry on the desktop as well. It uses three options: Show, don't show, and decide based on form factor.

We could drop the ability to hide it on the desktop in favour of making it a boolean but I'd vote for the more flexible current approach here.

« Back to merge proposal