Code review comment for lp:~nikwen/ubuntu-terminal-app/font-size-fix

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you for the review! :)

Here is a comparison of the font sizes with the current default: https://launchpadlibrarian.net/236776246/comparison.png

This shows that the values from the documentation are probably incorrect. However, you're right that it looks better on the phone with a ration of 1.0. In other words: perfect. So 10 might be better as the default.

For the range, have a look at this screenshot with maximum size: https://launchpadlibrarian.net/236776437/max-size.png
That's probably due to the incorrect desktop scaling again, though. On the phone, 50 is clearly too big.

We have to keep in mind to also consider cases where people want to present something using a projector. That's why we need a maximum that isn't too low.

« Back to merge proposal