Code review comment for lp:~nikwen/ubuntu-push/gmail-missed-messages-cleanup-fix-new

Niklas Wenzel (nikwen) wrote :

Yes, you were right. The flag didn't fulfil the purpose I wanted it to fulfil. Thanks!

What I wanted to do is make sure that the cleanup function doesn't get called too often when a user receives a lot of notifications. Hence, I have now adjusted the code to save the last time at which the cleanup function was called and to only call it from the addMessage() function when the last invocation has been at least 10 minutes back.

« Back to merge proposal