Merge lp:~nikwen/ubuntu-filemanager-app/zips into lp:ubuntu-filemanager-app

[Niklas Wenzel]

Add the ability to extract zip files. Like the ubuntu-download-manager this uses the unzip command line tool to extract the archives (http://bazaar.launchpad.net/~phablet-team/ubuntu-download-manager/trunk/revision/325).

Add the ability to extract zip files. Like the ubuntu-download-manager this uses the unzip command line tool to extract the archives (http://bazaar.launchpad.net/~phablet-team/ubuntu-download-manager/trunk/revision/325).

[Niklas Wenzel (nikwen)]

This one should contain all new files now. :)

[Arto Jalkanen (ajalkane)]

I have freshly updated image (r299) and I don't have unzip on my phone. So I can't say this or that to this merge request for now, perhaps it's coming in a later image?

Other than that, I'm just pondering... might it be more logical to have an Archiver application, that would register itself for Content-Hub for archives. Then clicking on a zip/tar/tar.gz file could have as target the Archiver where you could extract it. That way archives could be handled from other apps also not just from File Manager. I'm not sure how well Content-Hub is suited for such scenario, so this is just me thinking aloud.

review: Needs Information

[Carlos Jose Mazieri (carlos-mazieri)]

Hello guys,

How about having all open files stuff available to all applications not only for file manager?

It could be part of Content-Hub or a separated module, as Qt provides Qt::openUrlExternally() we would have something similar as Ubuntu API, so all applications can open files just calling one method.

review: Needs Information

[Alan Pope 🍺🐧🐱 🦄 (popey)]

unzip landed in the rtm image back on 16th Oct. See http://people.canonical.com/~ogra/touch-image-stats/rtm/112.changes

I'd recommend re-flashing (without wiping) your device using the "ubuntu-touch/ubuntu-rtm/14.09-proposed" channel.

Something like this should do it:-

ubuntu-device-flash --channel=ubuntu-touch/ubuntu-rtm/14.09-proposed

As an aside I'll find out why it didn't land in devel-proposed.

[Arto Jalkanen (ajalkane)]

With Alan Pope's instructions I got this branch working. Thanks a lot for the good work!

Is it possible to add a "cancel" button to the dialog where it's extracting files? Doing a call on external programs there's always a chance that things get stuck for a variety of reasons. Being able to cancel the operation in such situations is much preferable compared to user having to kill whole FileManager and starting anew.

But if the above suggestion is too much work for this merge proposal, I'll happily approve the current one. It's a great feature.

The image contains many more possibilities for extracting files, containing at least tar, gunzip and bzip2. After this commit lands to trunk I will file bugs to add support for more supported archives. If you can work on those too that'd be just great.

[Niklas Wenzel (nikwen)]

Thank you very much for reviewing this.
A cancel button looks like a good addition. I won't be able to look into this before the weekend but then I'll finally do it. I'll check how easy aborting a QProccess is.
I planned to enable extracting for more archive types anyway but I first wanted to make sure this one gets merged. Expect me to do some work on that matter. ;)

Some time ago, I looked into building an archiver application to push to the store as well but that proved to be fairly difficult as running commands like "unzip" or "tar" requires the application to run unconfined. One would therefore have to write a wrapper for respective Qt libraries so adding this functionality to the file manager seemed to be easier.

[Niklas Wenzel (nikwen)]

Just found a close() function so it should be possible: http://qt-project.org/doc/qt-5/qprocess.html#close

[Arto Jalkanen (ajalkane)]

> Just found a close() function so it should be possible: http://qt-
> project.org/doc/qt-5/qprocess.html#close

Great! If you can try to include that cancel into this merge request, that would be awesome. If it's not straightforward and requires more time then do comment and we'll merge this as it is, and you can continue on another branch on the cancel button.

Regarding the Content-Hub stuff me and Carlos were talking about. I think that would be better, but since it's not clear how well Content-Hub is suited for this kind of stuff it's probably best to leave for future to ponder about.

[Niklas Wenzel (nikwen)]

Hi, I'm sorry to say that but I didn't have the time to work on the cancel button (well, to do any coding) this weekend. I'll try to do it as soon as possible but I'll probably not be able to do it before next weekend.

[Arto Jalkanen (ajalkane)]

> Hi, I'm sorry to say that but I didn't have the time to work on the cancel
> button (well, to do any coding) this weekend. I'll try to do it as soon as
> possible but I'll probably not be able to do it before next weekend.

Thanks for the heads-up! Let's approve this change, and when you have time to work on the cancel button that would be a great improvement.

Thank you!

review: Approve

[Niklas Wenzel (nikwen)]

Thanks for approving this. I will for sure look into adding a cancel button and into adding more archive formats like tars as soon as I have time for that. :)

[Carlos Jose Mazieri (carlos-mazieri)]

OK. Let's release one more improvement to the filemanager.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/zips/+merge/239662/+edit-commit-message

review: Needs Fixing (continuous-integration)

[Niklas Wenzel (nikwen)]

Rerun autolanding

review: Approve

[Niklas Wenzel (nikwen)]

Hm, the comment above says the following: "You can approve the merge proposal yourself to rerun."
However, autolanding hasn't been rerun yet. Does anyone know how to trigger that properly?

[Arto Jalkanen (ajalkane)]

Needs top-level approve I think to rerun the tests. Done, let's see what happens.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/158/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/56
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-autolanding/1

review: Needs Fixing (continuous-integration)

[Niklas Wenzel (nikwen)]

Ah, thanks for doing this. I've never contributed code to the core apps before so I didn't know that.
Did I break the tests with my changes or have they been broken before as well?

[Arto Jalkanen (ajalkane)]

Can someone with autopilot/Jenkins test experience help with that? It seems like a newQML plugin "Archives" is not detected when running Jenkins. It's nevertheless built without problems locally.

[Niklas Wenzel (nikwen)]

@ajalkane: Would you mind retriggering the tests by doing another top-level approve? I don't seem to have the rights to do this.
The reason why I didn't look into this earlier was that I didn't find the test logs before...

[Niklas Wenzel (nikwen)]

Oh, sorry. I forgot to add a file. I'll add it now.

[Niklas Wenzel (nikwen)]

There you go. ;)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/160/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/152
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/152/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-autolanding/3

review: Needs Fixing (continuous-integration)

[Niklas Wenzel (nikwen)]

Ah, great. At least that worked now. Still two tests to fix though. I'll look into them later. ;)

[Niklas Wenzel (nikwen)]

Does anyone know what was wrong with the tests? I've never done automatic testing before and haven't managed to get the tests to run on my device. Anyone who could help me with that?
I just merged trunk as well. Maybe that will fix the tests. Would require another top-level approve to run them again though...

Thank you for your patience. :)

[Arto Jalkanen (ajalkane)]

Niklas,

it seems the "Cut" action somehow triggers extracting action in this new code:

http://91.189.93.70:8080/job/generic-mediumtests-vivid/152/artifact/filemanager.tests.test_filemanager.TestFolderListPage.test_cut_file.ogv

[Nicholas Skaggs (nskaggs)]

Looks like the test failures show 'cut'-ing a file brings up the extract archive prompt, which it shouldn't.

review: Needs Fixing

[Nicholas Skaggs (nskaggs)]

I would also like to see some tests added to support this new functionality. Ideally the tests would extract and verify a zip, but at least running through the menu options would be good.

review: Needs Fixing

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/162/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/258
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/258/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-autolanding/5

review: Needs Fixing (continuous-integration)

[Niklas Wenzel (nikwen)]

Ah, thank you very much for looking into this. That's something which I should be able to fix and I think I know why it happens. There is some strange behaviour regarding the visible attribute of an Action in an ActionList. Let me have a look at it this weekend. ;)

Regarding tests for archive extraction: I've never worked with autopilot before and, sadly, I don't have enough time to learn about automatic testing at the moment. (I'd love to do so much more coding but I can't...)
So if you really need them, someone else will have to do it for now.

[Arto Jalkanen (ajalkane)]

> Ah, thank you very much for looking into this. That's something which I should
> be able to fix and I think I know why it happens. There is some strange
> behaviour regarding the visible attribute of an Action in an ActionList. Let
> me have a look at it this weekend. ;)

Thanks!

> Regarding tests for archive extraction: I've never worked with autopilot
> before and, sadly, I don't have enough time to learn about automatic testing
> at the moment. (I'd love to do so much more coding but I can't...)
> So if you really need them, someone else will have to do it for now.

That's understandable. If you can fix it so that existing tests run, maybe we can file a bug about the missing test cases for later implementation if that's okay with all parties?

[Niklas Wenzel (nikwen)]

I think my latest commit should fix the issue for now. It's actually a workaround since the bug is in the code for the ActionSelectionPopover. It doesn't set the visible property of the list items to false according to the visible property of the Action.
I'll file a bug and submit a merge proposal to upstream tomorrow. Please don't approve that change until then so that I can add the issue and MP links to the comment in the code. ;)

Thanks. :)

[Nicholas Skaggs (nskaggs)]

Can you link the bug you worked around in source please?

[Niklas Wenzel (nikwen)]

> Can you link the bug you worked around in source please?

That's exactly what I wanted to do. I just filed the bug report, created a merge proposal for the UI Toolkit and adjusted the comment (as well as the workaround code so that it's like in the other MP).
Could someone please do a top-level approve again to see whether it passes the tests? I think it will.
Thanks to all of you for your help and patience. :)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-autolanding/164/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/340
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/340/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-autolanding/7

review: Needs Fixing (continuous-integration)

[lp:~nikwen/ubuntu-filemanager-app/zips]

320. By Niklas Wenzel on 2014-11-23

Fixed variable name

[Niklas Wenzel (nikwen)]

Ah, sorry. I forgot to change a variable name when copying the workaround code into the filemanager code.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:320
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/405/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/367
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/367/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/27

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/405/rebuild

review: Approve (continuous-integration)

[Niklas Wenzel (nikwen)]

Thanks for approving it again. I'm glad it finally passed the tests.
Why is its status still "Needs review"? May I change it to "Approved"? (I do now have the ability to do that for some reason.)

[Niklas Wenzel (nikwen)]

Ah, I know why I am able to approve this now if I want to. For some reason I was added to the "Ubuntu Core Apps Test Writers" team which makes me an indirect member of the file manager app team.
Nicholas, would you mind telling me why I was added to that team (not that I want to leave it :p)?

[Nicholas Skaggs (nskaggs)]

Niklas I added you to the team so jenkins would automatically build things for you. You've helped out in several core apps, it makes sense to have jenkins autorun on your mp's :-)

[Niklas Wenzel (nikwen)]

Thank you very much, Nicholas. I really appreciate it. :)

My other question still remains though: Is there still anything missing to get this merged? Or will it be done automatically later?

[Arto Jalkanen (ajalkane)]

> My other question still remains though: Is there still anything missing to get
> this merged?

Nope, I will try top-approving again and it should get merged if there's no issues.

[Arto Jalkanen (ajalkane)]

> My other question still remains though: Is there still anything missing to get
> this merged?

Nope, I will try top-approving again and it should get merged if there's no issues.

[Niklas Wenzel (nikwen)]

Ok, great. So it was finally merged. :)
I'll file issues for missing features in the extraction process (like the cancel button or other archive types) tomorrow and assign as many as I can deal with to me.

Thank you very, very much. :)

[Arto Jalkanen (ajalkane)]

No, thank you very much for your great contributions to make File Manager better! I'm very happy that this gets now merged.

Hopeful to see more contributions when you have the time, and it's a big help even if it's filing bug reports as then we have something concrete to track on!

[Niklas Wenzel (nikwen)]

Ok, I didn't have the time today to file those bugs but I will definitely do that as soon as possible.
For now, there's the MP for extracting tar archives. ;)
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/tars/+merge/240986

[Niklas Wenzel (nikwen)]

Here are the bugs I reported:

https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1397058
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1397060
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1397070
https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1397072

=== modified file 'debian/control'
--- debian/control	2014-09-04 02:37:45 +0000
+++ debian/control	2014-11-23 14:40:50 +0000
@@ -24,6 +24,7 @@
          qtdeclarative5-nemo-qml-plugin-folderlistmodel,
          qtdeclarative5-placesmodel0.1,
          qtdeclarative5-pamauthentication0.1,
+         qtdeclarative5-archives0.1,
          qtdeclarative5-qtquick2-plugin,
          qtdeclarative5-u1db1.0,
          qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
@@ -64,6 +65,16 @@
  This package contains a plugin that enables QML apps to do
  password authentication via the PAM API.
 
+Package: qtdeclarative5-archives0.1
+Architecture: any
+Multi-Arch: same
+Depends: ${misc:Depends},
+         ${shlibs:Depends},
+         ${misc:Pre-Depends},
+Description: Archives QML plugin
+ This package contains a plugin that enables QML apps to extract
+ archive files.
+
 Package: ubuntu-filemanager-app-autopilot
 Architecture: all
 Depends: ${misc:Depends},
 
=== added file 'debian/qtdeclarative5-archives0.1.install'
--- debian/qtdeclarative5-archives0.1.install	1970-01-01 00:00:00 +0000
+++ debian/qtdeclarative5-archives0.1.install	2014-11-23 14:40:50 +0000
@@ -0,0 +1,1 @@
+usr/lib/*/qt5/qml/com/ubuntu/Archives/
 
=== modified file 'po/com.ubuntu.filemanager.pot'
--- po/com.ubuntu.filemanager.pot	2014-11-19 21:03:49 +0000
+++ po/com.ubuntu.filemanager.pot	2014-11-23 14:40:50 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2014-11-19 21:32+0100\n"
+"POT-Creation-Date: 2014-11-23 15:38+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -31,7 +31,7 @@
 msgstr ""
 
 #: ../src/app/qml/components/PathHistoryRow.qml:84
-#: ../src/app/qml/ui/FolderListPage.qml:620
+#: ../src/app/qml/ui/FolderListPage.qml:753
 msgid "Device"
 msgstr ""
 
@@ -44,7 +44,7 @@
 msgid "Open with"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:81 ../src/app/qml/ui/FolderListPage.qml:102
+#: ../src/app/qml/filemanager.qml:81 ../src/app/qml/ui/FolderListPage.qml:103
 #: ../src/app/qml/ui/SettingsSheet.qml:31
 msgid "Settings"
 msgstr ""
@@ -53,12 +53,12 @@
 msgid "Change app settings"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:259 ../src/app/qml/ui/FolderListPage.qml:352
+#: ../src/app/qml/filemanager.qml:259 ../src/app/qml/ui/FolderListPage.qml:353
 #: ../src/app/qml/ui/ViewPopover.qml:70
 msgid "Icons"
 msgstr ""
 
-#: ../src/app/qml/filemanager.qml:259 ../src/app/qml/ui/FolderListPage.qml:368
+#: ../src/app/qml/filemanager.qml:259 ../src/app/qml/ui/FolderListPage.qml:369
 #: ../src/app/qml/ui/ViewPopover.qml:71
 msgid "List"
 msgstr ""
@@ -87,7 +87,7 @@
 #: ../src/app/qml/ui/ConfirmDialogWithInput.qml:57
 #: ../src/app/qml/ui/FileActionDialog.qml:45
 #: ../src/app/qml/ui/FileOperationProgressDialog.qml:44
-#: ../src/app/qml/ui/FolderListPage.qml:330
+#: ../src/app/qml/ui/FolderListPage.qml:331
 #: ../src/app/qml/ui/GoToDialog.qml:66
 msgid "Cancel"
 msgstr ""
@@ -149,151 +149,182 @@
 msgid "File operation"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:52
+#: ../src/app/qml/ui/FolderListPage.qml:53
 #, qt-format
 msgid "Paste %1 File"
 msgid_plural "Paste %1 Files"
 msgstr[0] ""
 msgstr[1] ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:56
+#: ../src/app/qml/ui/FolderListPage.qml:57
 msgid "Paste files"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:64
+#: ../src/app/qml/ui/FolderListPage.qml:65
 msgid "Clear clipboard"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:74
-#: ../src/app/qml/ui/FolderListPage.qml:92
-#: ../src/app/qml/ui/FolderListPage.qml:511
+#: ../src/app/qml/ui/FolderListPage.qml:75
+#: ../src/app/qml/ui/FolderListPage.qml:93
+#: ../src/app/qml/ui/FolderListPage.qml:589
 msgid "Properties"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:83
+#: ../src/app/qml/ui/FolderListPage.qml:84
 msgid "New Folder"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:109
+#: ../src/app/qml/ui/FolderListPage.qml:110
 msgid "Go To"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:116
+#: ../src/app/qml/ui/FolderListPage.qml:117
 msgid "Unlock full access"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:130
+#: ../src/app/qml/ui/FolderListPage.qml:131
 msgid "Authentication failed"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:202
+#: ../src/app/qml/ui/FolderListPage.qml:203
 #, qt-format
 msgid "%1 file"
 msgid_plural "%1 files"
 msgstr[0] ""
 msgstr[1] ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:227
+#: ../src/app/qml/ui/FolderListPage.qml:228
 msgid "Open in a new tab"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:235
+#: ../src/app/qml/ui/FolderListPage.qml:236
 msgid "Close this tab"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:248
+#: ../src/app/qml/ui/FolderListPage.qml:249
 msgid "Create folder"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:249
+#: ../src/app/qml/ui/FolderListPage.qml:250
 msgid "Enter name for new folder"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:265
+#: ../src/app/qml/ui/FolderListPage.qml:266
 msgid "Create file"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:266
+#: ../src/app/qml/ui/FolderListPage.qml:267
 msgid "Enter name for new file"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:315
+#: ../src/app/qml/ui/FolderListPage.qml:316
 msgid "Select"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:383
+#: ../src/app/qml/ui/FolderListPage.qml:384
 msgid "No files"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:403
-#: ../src/app/qml/ui/FolderListPage.qml:485
+#: ../src/app/qml/ui/FolderListPage.qml:404
+#: ../src/app/qml/ui/FolderListPage.qml:551
 msgid "Delete"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:404
+#: ../src/app/qml/ui/FolderListPage.qml:405
 #, qt-format
 msgid "Are you sure you want to permanently delete '%1'?"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:409
+#: ../src/app/qml/ui/FolderListPage.qml:410
 msgid "Deleting files"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:427
-#: ../src/app/qml/ui/FolderListPage.qml:498
+#: ../src/app/qml/ui/FolderListPage.qml:428
+#: ../src/app/qml/ui/FolderListPage.qml:564
 msgid "Rename"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:428
+#: ../src/app/qml/ui/FolderListPage.qml:429
 msgid "Enter a new name"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:437
+#: ../src/app/qml/ui/FolderListPage.qml:438
 msgid "Could not rename"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:438
+#: ../src/app/qml/ui/FolderListPage.qml:439
 msgid "Insufficient permissions or name already exists?"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:462
+#: ../src/app/qml/ui/FolderListPage.qml:456
+msgid "Extract Archive"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:457
+#, qt-format
+msgid "Are you sure you want to extract '%1' here?"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:528
 msgid "Cut"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:473
+#: ../src/app/qml/ui/FolderListPage.qml:539
 msgid "Copy"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:531
+#: ../src/app/qml/ui/FolderListPage.qml:579
+msgid "Extract archive"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:609
 msgid "File operation error"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:591
+#: ../src/app/qml/ui/FolderListPage.qml:640
+#, qt-format
+msgid "Extracting archive '%1'"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:652
+msgid "OK"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:666
+msgid "Extracting failed"
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:667
+#, qt-format
+msgid "Extracting the archive '%1' failed."
+msgstr ""
+
+#: ../src/app/qml/ui/FolderListPage.qml:724
 msgid "~/Desktop"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:601
+#: ../src/app/qml/ui/FolderListPage.qml:734
 msgid "~/Public"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:603
+#: ../src/app/qml/ui/FolderListPage.qml:736
 msgid "~/Programs"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:605
+#: ../src/app/qml/ui/FolderListPage.qml:738
 msgid "~/Templates"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:618
+#: ../src/app/qml/ui/FolderListPage.qml:751
 msgid "Home"
 msgstr ""
 
-#: ../src/app/qml/ui/FolderListPage.qml:688
+#: ../src/app/qml/ui/FolderListPage.qml:821
 msgid "Folder not accessible"
 msgstr ""
 
 #. TRANSLATORS: this refers to a folder name
-#: ../src/app/qml/ui/FolderListPage.qml:690
+#: ../src/app/qml/ui/FolderListPage.qml:823
 #, qt-format
 msgid "Can not access %1"
 msgstr ""
 
=== modified file 'src/app/qml/ui/FolderListPage.qml'
--- src/app/qml/ui/FolderListPage.qml	2014-11-01 23:44:58 +0000
+++ src/app/qml/ui/FolderListPage.qml	2014-11-23 14:40:50 +0000
@@ -21,6 +21,7 @@
 import Ubuntu.Components.ListItems 1.0
 import org.nemomobile.folderlistmodel 1.0
 import com.ubuntu.PlacesModel 0.1
+import com.ubuntu.Archives 0.1
 import "../components"
 import "../upstream"
 
@@ -448,6 +449,45 @@
     }
 
     Component {
+        id: confirmExtractDialog
+        ConfirmDialog {
+            property string filePath
+            property string fileName
+            title: i18n.tr("Extract Archive")
+            text: i18n.tr("Are you sure you want to extract '%1' here?").arg(fileName)
+
+            onAccepted: {
+                console.log("Extract accepted for filePath, fileName", filePath, fileName)
+                PopupUtils.open(extractingDialog, mainView, { "fileName" : fileName })
+                console.log("Extracting...")
+
+                var parentDirectory = filePath.substring(0, filePath.lastIndexOf("/"))
+                var fileNameWithoutExtension = fileName.substring(0, fileName.lastIndexOf("."))
+                var extractDirectory = parentDirectory + "/" + fileNameWithoutExtension
+
+                // Add numbers if the directory already exist: myfile, myfile-1, myfile-2, etc.
+                while (pageModel.existsDir(extractDirectory)) {
+                    var i = 0
+                    while ("1234567890".indexOf(extractDirectory.charAt(extractDirectory.length - i - 1)) !== -1) {
+                        i++
+                    }
+                    if (i === 0 || extractDirectory.charAt(extractDirectory.length - i - 1) !== "-") {
+                        extractDirectory += "-1"
+                    } else {
+                        extractDirectory = extractDirectory.substring(0, extractDirectory.lastIndexOf("-") + 1) + (parseInt(extractDirectory.substring(extractDirectory.length - i)) + 1)
+                    }
+                }
+
+                archives.extractZip(filePath, extractDirectory)
+            }
+        }
+    }
+
+    Archives {
+        id: archives
+    }
+
+    Component {
         id: actionSelectionPopoverComponent
 
         ActionSelectionPopover {
@@ -457,6 +497,32 @@
             grabDismissAreaEvents: true
 
             property var model
+
+            property bool isArchive: false
+
+            Component.onCompleted: {
+                var splitName = actionSelectionPopover.model.fileName.split(".")
+                var fileExtension = splitName[splitName.length - 1]
+                isArchive = fileExtension === "zip"
+            }
+
+            delegate: Empty { // NOTE: This is a workaround for LP: #1395118 and should be removed as soon as the patch for upstream gets released (https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1395118)
+                id: listItem
+                Label {
+                    text: listItem.text
+                    anchors {
+                        verticalCenter: parent.verticalCenter
+                        horizontalCenter: parent.horizontalCenter
+                    }
+                    wrapMode: Text.Wrap
+                    color: Theme.palette.normal.overlayText
+                }
+                /*! \internal */
+                onTriggered: actionSelectionPopover.hide()
+                visible: enabled && ((action === undefined) || action.visible)
+                height: visible ? implicitHeight : 0
+            }
+
             actions: ActionList {
                 Action {
                     text: i18n.tr("Cut")
@@ -508,6 +574,18 @@
                 }
 
                 Action {
+                    id: extractAction
+                    visible: actionSelectionPopover.isArchive
+                    text: i18n.tr("Extract archive")
+                    onTriggered: {
+                        PopupUtils.open(confirmExtractDialog, actionSelectionPopover.caller,
+                                        { "filePath" : actionSelectionPopover.model.filePath,
+                                            "fileName" : actionSelectionPopover.model.fileName }
+                                        )
+                    }
+                }
+
+                Action {
                     text: i18n.tr("Properties")
 
                     onTriggered: {
@@ -539,6 +617,61 @@
         model: pageModel
     }
 
+    Component {
+        id: extractingDialog
+
+        Dialog {
+            id: dialog
+            modal: true
+            property string fileName: ""
+
+            Row {
+                id: row
+                width: parent.width
+                spacing: units.gu(2)
+
+                ActivityIndicator {
+                    id: loadingSpinner
+                    running: true
+                    anchors.verticalCenter: parent.verticalCenter
+                }
+
+                Label {
+                    text: qsTr(i18n.tr("Extracting archive '%1'")).arg(fileName)
+                    color: UbuntuColors.darkGrey
+                    anchors.verticalCenter: parent.verticalCenter
+                    width: row.width - loadingSpinner.width - row.spacing
+                    maximumLineCount: 2
+                    wrapMode: Text.WrapAnywhere
+                    elide: Text.ElideRight
+                }
+            }
+
+            Button {
+                id: button
+                text: i18n.tr("OK")
+                visible: false
+                onClicked: {
+                    PopupUtils.close(dialog)
+                }
+            }
+
+            Connections {
+                target: archives
+                onFinished: {
+                    if (success) {
+                        PopupUtils.close(dialog)
+                    } else {
+                        row.visible = false
+                        title = i18n.tr("Extracting failed")
+                        text = qsTr(i18n.tr("Extracting the archive '%1' failed.")).arg(fileName)
+                        button.visible = true
+                    }
+                }
+            }
+        }
+    }
+
     function goTo(location) {
         // This allows us to enter "~" as a shortcut to the home folder
         // when entering a location on the Go To dialog
 
=== modified file 'src/plugin/CMakeLists.txt'
--- src/plugin/CMakeLists.txt	2014-08-01 21:02:45 +0000
+++ src/plugin/CMakeLists.txt	2014-11-23 14:40:50 +0000
@@ -7,3 +7,4 @@
 add_subdirectory(folderlistmodel)
 add_subdirectory(placesmodel)
 add_subdirectory(pamauthentication)
+add_subdirectory(archives)
 
=== added directory 'src/plugin/archives'
=== added file 'src/plugin/archives/CMakeLists.txt'
--- src/plugin/archives/CMakeLists.txt	1970-01-01 00:00:00 +0000
+++ src/plugin/archives/CMakeLists.txt	2014-11-23 14:40:50 +0000
@@ -0,0 +1,35 @@
+include_directories(
+    ${CMAKE_CURRENT_SOURCE_DIR}
+)
+
+set(PLUGIN_DIR com/ubuntu/Archives)
+
+set(archives_SRCS
+    archives.cpp
+    archives.h
+    archives_plugin.cpp
+    archives_plugin.h
+)
+
+add_library(Archives MODULE
+    ${archives_SRCS}
+)
+
+qt5_use_modules(Archives Gui Qml Quick Widgets)
+
+# Copy the plugin, the qmldir file and other assets to the build dir for running in QtCreator
+if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
+    add_custom_command(TARGET Archives POST_BUILD
+        COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}
+        COMMENT "Creating plugin directory layout in the build directory"
+        COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/qmldir ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}
+        COMMENT "Copying the qmldir file to the build directory"
+        COMMAND ${CMAKE_COMMAND} -E copy $<TARGET_FILE:Archives> ${CMAKE_CURRENT_BINARY_DIR}/../${PLUGIN_DIR}
+        COMMENT "Copying the plugin binary to the build directory"
+    )
+endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
+
+# Install plugin file
+install(TARGETS Archives DESTINATION ${QT_IMPORTS_DIR}/${PLUGIN_DIR})
+install(FILES qmldir DESTINATION ${QT_IMPORTS_DIR}/${PLUGIN_DIR})
+
 
=== added file 'src/plugin/archives/archives.cpp'
--- src/plugin/archives/archives.cpp	1970-01-01 00:00:00 +0000
+++ src/plugin/archives/archives.cpp	2014-11-23 14:40:50 +0000
@@ -0,0 +1,57 @@
+/*
+ * Copyright (C) 2014 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author : Niklas Wenzel <[e-mail]>
+ */
+
+#include "archives.h"
+#include "QDebug"
+
+void Archives::extractZip(const QString path, const QString destination)
+{
+    if (_process != nullptr && _process->state() == QProcess::ProcessState::Running) {
+        return; // Do not allow two extractions running in parallel. Due to the way this is used in QML parallelization is not needed.
+    }
+
+    QString program = "unzip"; // This programm is available in the images as it is one of the dependencies of the ubuntu-download-manager package.
+    QStringList arguments;
+    arguments << path << "-d" << destination;
+
+    _process = new QProcess(this);
+
+    // Connect to internal slots in order to have one unified onFinished slot handling both events for QML.
+    connect(_process,
+            static_cast<void(QProcess::*)(int, QProcess::ExitStatus)>
+            (&QProcess::finished), this, &Archives::_onFinished);
+    connect(_process,
+            static_cast<void(QProcess::*)(QProcess::ProcessError)>
+            (&QProcess::error), this, &Archives::_onError);
+
+    _process->start(program, arguments);
+}
+
+void Archives::_onError(QProcess::ProcessError error)
+{
+    emit finished(false, error);
+}
+
+void Archives::_onFinished(int exitCode, QProcess::ExitStatus exitStatus)
+{
+    if ((exitStatus == QProcess::NormalExit || exitCode == 0) && _process->readAllStandardError().isEmpty()) {
+        emit finished(true, -1);
+    } else {
+        emit finished(false, -1);
+    }
+}
 
=== added file 'src/plugin/archives/archives.h'
--- src/plugin/archives/archives.h	1970-01-01 00:00:00 +0000
+++ src/plugin/archives/archives.h	2014-11-23 14:40:50 +0000
@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2014 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author : Niklas Wenzel <[e-mail]>
+ */
+
+#ifndef ARCHIVES_H
+#define ARCHIVES_H
+
+#include <QObject>
+#include <QProcess>
+
+class Archives : public QObject
+{
+    Q_OBJECT
+
+public:
+    Q_INVOKABLE void extractZip(const QString path, const QString destination);
+
+signals:
+    void finished(bool success, int errorCode);
+
+private slots:
+    void _onError(QProcess::ProcessError error);
+    void _onFinished(int exitCode, QProcess::ExitStatus exitStatus);
+
+private:
+    QProcess* _process = nullptr;
+};
+
+
+#endif // ARCHIVES_H
 
=== added file 'src/plugin/archives/archives_plugin.cpp'
--- src/plugin/archives/archives_plugin.cpp	1970-01-01 00:00:00 +0000
+++ src/plugin/archives/archives_plugin.cpp	2014-11-23 14:40:50 +0000
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2014 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author : Niklas Wenzel <[e-mail]>
+ */
+
+#include <QtQml>
+#include <QtQml/QQmlContext>
+#include "archives_plugin.h"
+#include "archives.h"
+
+void BackendPlugin::registerTypes(const char *uri)
+{
+    Q_ASSERT(uri == QLatin1String("com.ubuntu.Archives"));
+
+    qmlRegisterType<Archives>(uri, 0, 1, "Archives");
+}
+
+void BackendPlugin::initializeEngine(QQmlEngine *engine, const char *uri)
+{
+    QQmlExtensionPlugin::initializeEngine(engine, uri);
+}
 
=== added file 'src/plugin/archives/archives_plugin.h'
--- src/plugin/archives/archives_plugin.h	1970-01-01 00:00:00 +0000
+++ src/plugin/archives/archives_plugin.h	2014-11-23 14:40:50 +0000
@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) 2014 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Author : Niklas Wenzel <[e-mail]>
+ */
+
+#ifndef ARCHIVES_PLUGIN_H
+#define ARCHIVES_PLUGIN_H
+
+#include <QtQml/QQmlEngine>
+#include <QtQml/QQmlExtensionPlugin>
+
+class BackendPlugin : public QQmlExtensionPlugin
+{
+    Q_OBJECT
+    Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface")
+
+public:
+    void registerTypes(const char *uri);
+    void initializeEngine(QQmlEngine *engine, const char *uri);
+};
+#endif // ARCHIVES_PLUGIN_H
+
+
+
+
+
 
=== added file 'src/plugin/archives/qmldir'
--- src/plugin/archives/qmldir	1970-01-01 00:00:00 +0000
+++ src/plugin/archives/qmldir	2014-11-23 14:40:50 +0000
@@ -0,0 +1,2 @@
+module com.ubuntu.Archives
+plugin Archives