Merge lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls into lp:ubuntu-calendar-app

Proposed by Niklas Wenzel
Status: Merged
Approved by: Mihir Soni
Approved revision: 723
Merged at revision: 725
Proposed branch: lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls
Merge into: lp:ubuntu-calendar-app
Diff against target: 25 lines (+2/-2)
2 files modified
DayView.qml (+1/-1)
MonthView.qml (+1/-1)
To merge this branch: bzr merge lp:~nikwen/ubuntu-calendar-app/remove-unnecessary-i18n-calls
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+278228@code.launchpad.net

Commit message

Remove unnecessary i18n.tr() calls

Description of the change

Remove unnecessary i18n.tr() calls

Please note that I haven't tested this change.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me !!

Revision history for this message
Mihir Soni (mihirsoni) wrote :

Lgtm , Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'DayView.qml'
--- DayView.qml 2015-02-18 19:27:20 +0000
+++ DayView.qml 2015-11-20 23:10:10 +0000
@@ -56,7 +56,7 @@
56 id:monthYear56 id:monthYear
57 objectName:"monthYearLabel"57 objectName:"monthYearLabel"
58 fontSize: "x-large"58 fontSize: "x-large"
59 text: i18n.tr(currentDay.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy")))59 text: currentDay.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy"))
60 font.capitalization: Font.Capitalize60 font.capitalization: Font.Capitalize
61 }61 }
62 }62 }
6363
=== modified file 'MonthView.qml'
--- MonthView.qml 2015-09-05 05:33:38 +0000
+++ MonthView.qml 2015-11-20 23:10:10 +0000
@@ -57,7 +57,7 @@
57 // TRANSLATORS: this is a time formatting string,57 // TRANSLATORS: this is a time formatting string,
58 // see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid expressions.58 // see http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid expressions.
59 // It's used in the header of the month and week views59 // It's used in the header of the month and week views
60 text: i18n.tr(currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy")))60 text: currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy"))
61 font.capitalization: Font.Capitalize61 font.capitalization: Font.Capitalize
62 }62 }
63 }63 }

Subscribers

People subscribed via source and target branches

to status/vote changes: