Ubuntu Calendar App

Code review comment for lp:~nikwen/ubuntu-calendar-app/fix-standalone-month-name-i18n

  1. fix-standalone-month-name-i18n
  2. Merge into trunk
Revision history for this message
David Planella (dpm) wrote :

I've just double-checked this again, and I can confirm that the qsTr() call is not required. i18n.tr() (gettext) already takes care of the format string, it is not necessary to process it again with qsTr().

This can easily be tested with a simple QML app that includes the following string:

i18n.tr("%1 %2").arg(Qt.locale().standaloneMonthName(10, Locale.LongFormat)).arg("2011")

review: Needs Fixing
Reply

« Back to merge proposal