Merge lp:~nik90/unav/use-loader into lp:unav

Proposed by Nekhelesh Ramananthan
Status: Merged
Merged at revision: 13
Proposed branch: lp:~nik90/unav/use-loader
Merge into: lp:unav
Diff against target: 123 lines (+44/-41)
2 files modified
manifest.json (+1/-1)
qml/Main.qml (+43/-40)
To merge this branch: bzr merge lp:~nik90/unav/use-loader
Reviewer Review Type Date Requested Status
uNav developers Pending
Review via email: mp+290632@code.launchpad.net

Commit message

- Moved actionBarRow into a Loader
- Simplified bindings in actionButtonRow and zoomSplashColumn
- Updated framework to 15.04.3 (available in stable images)

Description of the change

- Moved actionBarRow into a Loader
- Simplified bindings in actionButtonRow and zoomSplashColumn
- Updated framework to 15.04.3 (available in stable images)

To post a comment you must log in.
Revision history for this message
costales (costales) wrote :

Hi :) Is OK for you Joerg? :)

Revision history for this message
JkB (joergberroth) wrote :

yes

Am 2016-03-31 um 19:22 schrieb costales:
> Hi :) Is OK for you Joerg? :)
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'manifest.json'
--- manifest.json 2016-03-28 17:31:47 +0000
+++ manifest.json 2016-03-31 16:31:46 +0000
@@ -1,7 +1,7 @@
1{1{
2 "architecture": "all",2 "architecture": "all",
3 "description": "turn-by-turn GPS Navigation",3 "description": "turn-by-turn GPS Navigation",
4 "framework": "ubuntu-sdk-15.04",4 "framework": "ubuntu-sdk-15.04.3",
5 "hooks": {5 "hooks": {
6 "navigator": {6 "navigator": {
7 "apparmor": "app-armor.json",7 "apparmor": "app-armor.json",
88
=== modified file 'qml/Main.qml'
--- qml/Main.qml 2016-03-28 19:31:48 +0000
+++ qml/Main.qml 2016-03-31 16:31:46 +0000
@@ -395,45 +395,48 @@
395 }395 }
396 }396 }
397397
398 Row {398 Loader {
399 id: actionButtonRow399 id: actionButtonRowLoader
400400 sourceComponent: !header.visible ? actionButtonRowComponent : undefined
401 anchors { right: parent.right; top: parent.top; margins: units.gu(1) }401 anchors { right: parent.right; top: parent.top; margins: units.gu(1) }
402402 }
403 ActionIcon {403
404 icon.name: "send"404 Component {
405 visible: !header.visible405 id: actionButtonRowComponent
406 enabled: navigationPage.buttonsEnabled406 Row {
407 onClicked: mainPageStack.push(Qt.resolvedUrl("RoutePage.qml"))407 id: actionButtonRow
408 }408
409409 opacity: navigationPage.buttonsEnabled ? 1.0 : 0.3
410 ActionIcon {410
411 icon.source: mainPageStack.center_onpos ? (mainPageStack.center_onpos === 1 ? "../nav/img/header/center_onpos.svg"411 ActionIcon {
412 : "../nav/img/header/center_onpos_light.svg")412 icon.name: "send"
413 : navigationPage.buttonsEnabled ? "../nav/img/header/gps_off.svg"413 enabled: navigationPage.buttonsEnabled
414 : "../nav/img/header/gps_off_light.svg"414 onClicked: mainPageStack.push(Qt.resolvedUrl("RoutePage.qml"))
415 visible: !header.visible415 }
416 enabled: navigationPage.buttonsEnabled && mainPageStack.center_onpos !== 2416
417 onClicked: {417 ActionIcon {
418 mainPageStack.center_onpos = 2;418 icon.source: mainPageStack.center_onpos ? (mainPageStack.center_onpos === 1 ? "../nav/img/header/center_onpos.svg"
419 goThereActionPopover.hide();419 : "../nav/img/header/center_onpos_light.svg")
420 mainPageStack.executeJavaScript("center_pos()");420 : "../nav/img/header/gps_off.svg"
421 }421 enabled: navigationPage.buttonsEnabled && mainPageStack.center_onpos !== 2
422 }422 onClicked: {
423423 mainPageStack.center_onpos = 2;
424 ActionIcon {424 goThereActionPopover.hide();
425 icon.source: navigationPage.buttonsEnabled ? "../nav/img/header/fullscreen.svg"425 mainPageStack.executeJavaScript("center_pos()");
426 : "../nav/img/header/fullscreen_light.svg"426 }
427 visible: !header.visible427 }
428 enabled: navigationPage.buttonsEnabled428
429 onClicked: navApp.settings.headerVisible = !navApp.settings.headerVisible;429 ActionIcon {
430 }430 icon.name: "view-restore"
431431 enabled: navigationPage.buttonsEnabled
432 ActionIcon {432 onClicked: navApp.settings.headerVisible = !navApp.settings.headerVisible;
433 icon.name: "settings"433 }
434 visible: !header.visible434
435 enabled: navigationPage.buttonsEnabled435 ActionIcon {
436 onClicked: mainPageStack.push(Qt.resolvedUrl("SettingsPage.qml"))436 icon.name: "settings"
437 enabled: navigationPage.buttonsEnabled
438 onClicked: mainPageStack.push(Qt.resolvedUrl("SettingsPage.qml"))
439 }
437 }440 }
438 }441 }
439442
@@ -447,17 +450,17 @@
447 verticalCenterOffset: units.gu(2)450 verticalCenterOffset: units.gu(2)
448 }451 }
449452
453 visible: navigationPage.buttonsEnabled
454
450 ActionIcon {455 ActionIcon {
451 icon.name: "zoom-in"456 icon.name: "zoom-in"
452 icon.width: units.gu(4)457 icon.width: units.gu(4)
453 visible: navigationPage.buttonsEnabled
454 onClicked: mainPageStack.executeJavaScript("custom_zoom(1)")458 onClicked: mainPageStack.executeJavaScript("custom_zoom(1)")
455 }459 }
456460
457 ActionIcon {461 ActionIcon {
458 icon.name: "zoom-out"462 icon.name: "zoom-out"
459 icon.width: units.gu(4)463 icon.width: units.gu(4)
460 visible: navigationPage.buttonsEnabled
461 onClicked: mainPageStack.executeJavaScript("custom_zoom(-1)")464 onClicked: mainPageStack.executeJavaScript("custom_zoom(-1)")
462 }465 }
463 }466 }

Subscribers

People subscribed via source and target branches