Code review comment for lp:~nik90/unav/remove-local-icon-assets

Revision history for this message
JkB (joergberroth) wrote :

Hey there,

there is a regression in this.
On rc-proposed on phone,
The header does not behave as expected anymore.
The slots change position.
Seems that the header does not work properly with the
visible/enabled states.
Please review again, mybe again a behaviour only on phone..

this works for me:
http://pastebin.ubuntu.com/15579691/

And who and why do we have those strange icons (light, etc.) in?
And when did they get in?

Best Joerg

Am 2016-04-01 um 18:14 schrieb costales:
> Review: Approve
>
> Thanks
>
> It's OK for me now. Anyway, it's so easy to see if there is a bug in a
future.
>
> @Joerg?
>

Am 2016-04-01 um 18:14 schrieb costales:
> Review: Approve
>
> Thanks :)
>
> It's OK for me now. Anyway, it's so easy to see if there is a bug in a future.
>
> @Joerg? :)
>

« Back to merge proposal