Ubuntu Weather App

Code review comment for lp:~nik90/ubuntu-weather-app/improved-settings-page

  1. improved-settings-page
  2. Merge into reboot
Revision history for this message
Victor Thompson (vthompson) wrote :

Actually, I just noticed a typo: "windSpeeModel" should be windSpeedModel

Additionally, and maybe this should be filed as a separate bug/issue to be tackled later because we would probably want Design input, but I think the Units ListModels should list "Celsius (°C)", "Inches (in)", etc. Also, I really think we need to have the Data Provider options be "Open Weather Map" and "The Weather Channel".

review: Needs Fixing

« Back to merge proposal