Code review comment for lp:~nik90/ubuntu-weather-app/improved-settings-page

> I think you need to ensure all the comparisons to some of the settings are
> made translatable as well eg [0], also ensure that none of the settings are
> directly used in api calls otherwise these could break if the stored value
> itself is translated.
>
> 0 - http://bazaar.launchpad.net/~nik90/ubuntu-weather-app/improved-settings-
> page/view/head:/app/ui/LocationPane.qml#L67

Nice catch! This issue would only affect the unit settings page as the other settings page like the dataprovider page requires no translation and the refresh interval page uses value instead of text to do the comparison.

Let me think about how I can fix the units settings page.