Code review comment for lp:~nik90/ubuntu-weather-app/improved-settings-page

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

I think you need to ensure all the comparisons to some of the settings are made translatable as well eg [0], also ensure that none of the settings are directly used in api calls otherwise these could break if the stored value itself is translated.

0 - http://bazaar.launchpad.net/~nik90/ubuntu-weather-app/improved-settings-page/view/head:/app/ui/LocationPane.qml#L67

review: Needs Information

« Back to merge proposal