Code review comment for lp:~nik90/ubuntu-weather-app/fix-ota10-sdk-issues

Victor Thompson (vthompson) wrote :

Functionally, issues #2 and #4 (recently added) are still occurring. I suspect Issues #4 is possibly an SDK issue--it affects Music as well. Although the code is probably similar, as I'm sure we borrowed the header state logic from Music.

Other comments on functionality:

1. Could we make the Settings and AddCityPage pages white to match the header? It is slightly off-white now and the header is white.
2. FastScroll is currently the light blue color--while it looks OK it doesn't fit the theme very well.

Code looks good at first glance--will need to actually review it.

review: Needs Fixing

« Back to merge proposal