> Currently, there is no trailing divider in the LocationsPage.
>
Btw were you referring to the divider of the trailing swipe actions? Or for the listitem as a whole?
I believe the default behaviour of the new listitems and UbuntuListView is to *not* show a divider for the very last item of the listview. If you add more locations, you will notice the divider being shown.
> The margins of the list items in the LocationsPage has been reduced in this MP
> --is that intentional?
>
Nope, I will fix this.
> Can we add a Select all/none toggle action to the multiselection on the
> LocationsPage?
>
> The settings page always seems to have the list items offset/partially down
> the page. This was introduced in the previous mp. Can we fix this behaviour?
>
This is something I have noticed while testing on rc-proposed channel. And not with the my BQ E4.5 runnign the stable channel. I can check with t1mp tomorrow as to why this is the case. And yes same behavior observed with Podbird while testing on Nexus 4 and BQ.
> I see a lot of instances of the following error message, can we fix this?
>
> file:///usr/lib/x86_64-linux-
> gnu/qt5/qml/Ubuntu/Components/Themes/Ambiance/PullToRefreshStyle.qml:94:
> TypeError: Cannot read property of null
I believe this is a SDK error message that is seen in other apps as well. I haven't changed the PullToRefresh component.
> Currently, there is no trailing divider in the LocationsPage.
>
Btw were you referring to the divider of the trailing swipe actions? Or for the listitem as a whole?
I believe the default behaviour of the new listitems and UbuntuListView is to *not* show a divider for the very last item of the listview. If you add more locations, you will notice the divider being shown.
> The margins of the list items in the LocationsPage has been reduced in this MP
> --is that intentional?
>
Nope, I will fix this.
> Can we add a Select all/none toggle action to the multiselection on the
> LocationsPage?
I'm afraid I can't. I have explained the reasoning at https:/ /code.launchpad .net/~nik90/ ubuntu- weather- app/finish- listitem- migration/ +merge/ 263136/ comments/ 659644. (it introduces another SDK bug which has been reported).
>
> The settings page always seems to have the list items offset/partially down
> the page. This was introduced in the previous mp. Can we fix this behaviour?
>
This is something I have noticed while testing on rc-proposed channel. And not with the my BQ E4.5 runnign the stable channel. I can check with t1mp tomorrow as to why this is the case. And yes same behavior observed with Podbird while testing on Nexus 4 and BQ.
> I see a lot of instances of the following error message, can we fix this? /usr/lib/ x86_64- linux- qml/Ubuntu/ Components/ Themes/ Ambiance/ PullToRefreshSt yle.qml: 94:
>
> file://
> gnu/qt5/
> TypeError: Cannot read property of null
I believe this is a SDK error message that is seen in other apps as well. I haven't changed the PullToRefresh component.