Merge lp:~nik90/ubuntu-weather-app/0-fix-broken-settings-links into lp:ubuntu-weather-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Martin Borho
Approved revision: 17
Merged at revision: 16
Proposed branch: lp:~nik90/ubuntu-weather-app/0-fix-broken-settings-links
Merge into: lp:ubuntu-weather-app
Diff against target: 126 lines (+24/-25)
3 files modified
app/ui/CMakeLists.txt (+1/-1)
app/ui/SettingsPage.qml (+3/-4)
po/com.ubuntu.weather.pot (+20/-20)
To merge this branch: bzr merge lp:~nik90/ubuntu-weather-app/0-fix-broken-settings-links
Reviewer Review Type Date Requested Status
Martin Borho Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+252112@code.launchpad.net

Commit message

Fxied the broken settings page links and also renamed Settings folder to settings to maintain consistency.

Description of the change

This MP fixes the broken settings page links and also renames Settings folder to settings to maintain consistency.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Martin Borho (martin-borho) wrote :

lgtm, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/ui/CMakeLists.txt'
--- app/ui/CMakeLists.txt 2015-02-09 19:49:06 +0000
+++ app/ui/CMakeLists.txt 2015-03-06 13:42:03 +0000
@@ -1,4 +1,4 @@
1add_subdirectory(Settings)1add_subdirectory(settings)
22
3file(GLOB UI_QML_JS_FILES *.qml *.js)3file(GLOB UI_QML_JS_FILES *.qml *.js)
44
55
=== modified file 'app/ui/SettingsPage.qml'
--- app/ui/SettingsPage.qml 2015-02-09 19:49:06 +0000
+++ app/ui/SettingsPage.qml 2015-03-06 13:42:03 +0000
@@ -20,7 +20,6 @@
20import Ubuntu.Components 1.120import Ubuntu.Components 1.1
21import Ubuntu.Components.ListItems 0.1 as ListItem21import Ubuntu.Components.ListItems 0.1 as ListItem
2222
23
24Page {23Page {
25 title: i18n.tr("Settings")24 title: i18n.tr("Settings")
2625
@@ -41,21 +40,21 @@
41 progression: true40 progression: true
42 text: i18n.tr("Units")41 text: i18n.tr("Units")
4342
44 onClicked: mainPageStack.push(Qt.resolvedUrl("Settings/UnitsPage.qml"))43 onClicked: mainPageStack.push(Qt.resolvedUrl("settings/UnitsPage.qml"))
45 }44 }
4645
47 ListItem.SingleValue {46 ListItem.SingleValue {
48 progression: true47 progression: true
49 text: i18n.tr("Data Provider")48 text: i18n.tr("Data Provider")
5049
51 onClicked: mainPageStack.push(Qt.resolvedUrl("Settings/DataProviderPage.qml"))50 onClicked: mainPageStack.push(Qt.resolvedUrl("settings/DataProviderPage.qml"))
52 }51 }
5352
54 ListItem.SingleValue {53 ListItem.SingleValue {
55 progression: true54 progression: true
56 text: i18n.tr("Refresh Interval")55 text: i18n.tr("Refresh Interval")
5756
58 onClicked: mainPageStack.push(Qt.resolvedUrl("Settings/RefreshIntervalPage.qml"))57 onClicked: mainPageStack.push(Qt.resolvedUrl("settings/RefreshIntervalPage.qml"))
59 }58 }
60 }59 }
61 }60 }
6261
=== renamed directory 'app/ui/Settings' => 'app/ui/settings'
=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot 2015-03-03 18:46:47 +0000
+++ po/com.ubuntu.weather.pot 2015-03-06 13:42:03 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: ubuntu-weather-app\n"9"Project-Id-Version: ubuntu-weather-app\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2015-03-03 18:45+0000\n"11"POT-Creation-Date: 2015-03-06 14:23+0100\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -65,46 +65,46 @@
65msgid "Locations"65msgid "Locations"
66msgstr ""66msgstr ""
6767
68#: ../app/ui/Settings/DataProviderPage.qml:25 ../app/ui/SettingsPage.qml:4968#: ../app/ui/SettingsPage.qml:25
69msgid "Settings"
70msgstr ""
71
72#: ../app/ui/SettingsPage.qml:42 ../app/ui/settings/UnitsPage.qml:25
73msgid "Units"
74msgstr ""
75
76#: ../app/ui/SettingsPage.qml:49 ../app/ui/settings/DataProviderPage.qml:25
69msgid "Data Provider"77msgid "Data Provider"
70msgstr ""78msgstr ""
7179
72#: ../app/ui/Settings/DataProviderPage.qml:4480#: ../app/ui/SettingsPage.qml:56 ../app/ui/settings/RefreshIntervalPage.qml:25
81msgid "Refresh Interval"
82msgstr ""
83
84#: ../app/ui/settings/DataProviderPage.qml:44
73msgid "Provider"85msgid "Provider"
74msgstr ""86msgstr ""
7587
76#: ../app/ui/Settings/RefreshIntervalPage.qml:25 ../app/ui/SettingsPage.qml:5688#: ../app/ui/settings/RefreshIntervalPage.qml:42
77msgid "Refresh Interval"
78msgstr ""
79
80#: ../app/ui/Settings/RefreshIntervalPage.qml:42
81msgid "minutes"89msgid "minutes"
82msgstr ""90msgstr ""
8391
84#: ../app/ui/Settings/RefreshIntervalPage.qml:4792#: ../app/ui/settings/RefreshIntervalPage.qml:47
85msgid "Interval"93msgid "Interval"
86msgstr ""94msgstr ""
8795
88#: ../app/ui/Settings/UnitsPage.qml:25 ../app/ui/SettingsPage.qml:4296#: ../app/ui/settings/UnitsPage.qml:44
89msgid "Units"
90msgstr ""
91
92#: ../app/ui/Settings/UnitsPage.qml:44
93msgid "Temperature"97msgid "Temperature"
94msgstr ""98msgstr ""
9599
96#: ../app/ui/Settings/UnitsPage.qml:56100#: ../app/ui/settings/UnitsPage.qml:56
97msgid "Precipitation"101msgid "Precipitation"
98msgstr ""102msgstr ""
99103
100#: ../app/ui/Settings/UnitsPage.qml:67104#: ../app/ui/settings/UnitsPage.qml:67
101msgid "Wind Speed"105msgid "Wind Speed"
102msgstr ""106msgstr ""
103107
104#: ../app/ui/SettingsPage.qml:25
105msgid "Settings"
106msgstr ""
107
108#: ubuntu-weather-app.desktop.in.in.h:1108#: ubuntu-weather-app.desktop.in.in.h:1
109msgid "Weather"109msgid "Weather"
110msgstr ""110msgstr ""

Subscribers

People subscribed via source and target branches