Merge lp:~nik90/ubuntu-clock-app/temp-fixes into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 69
Merged at revision: 69
Proposed branch: lp:~nik90/ubuntu-clock-app/temp-fixes
Merge into: lp:ubuntu-clock-app
Diff against target: 26 lines (+4/-1)
2 files modified
app/clock/ClockPage.qml (+3/-0)
app/ubuntu-clock-app.qml (+1/-1)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/temp-fixes
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Leo Arias (community) code review, compiled and viewed the labels. Approve
Review via email: mp+232315@code.launchpad.net

Commit message

Temporarily hides the location string and sets the bottom edge hint to "Alarms" until both these features are implemented.

Description of the change

Temporarily hides the location string and sets the bottom edge hint to "Alarms" until both these features are implemented.

I generally don't like hacks like this, but these will be removed by the next promotion image.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Thanks nik.

review: Approve (code review, compiled and viewed the labels.)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/clock/ClockPage.qml'
--- app/clock/ClockPage.qml 2014-08-24 12:47:50 +0000
+++ app/clock/ClockPage.qml 2014-08-26 20:31:13 +0000
@@ -123,6 +123,9 @@
123 opacity: settingsIcon.opacity123 opacity: settingsIcon.opacity
124 spacing: units.gu(1)124 spacing: units.gu(1)
125125
126 // TODO: Remove this once user location finding is implemented
127 visible: false
128
126 anchors {129 anchors {
127 top: date.bottom130 top: date.bottom
128 topMargin: units.gu(1)131 topMargin: units.gu(1)
129132
=== modified file 'app/ubuntu-clock-app.qml'
--- app/ubuntu-clock-app.qml 2014-08-24 12:47:50 +0000
+++ app/ubuntu-clock-app.qml 2014-08-26 20:31:13 +0000
@@ -100,7 +100,7 @@
100 #TODO: The bottom edge title should reflect the time to the next100 #TODO: The bottom edge title should reflect the time to the next
101 alarm. For instance it should read "Next alarm in 9h23m".101 alarm. For instance it should read "Next alarm in 9h23m".
102 */102 */
103 bottomEdgeTitle: i18n.tr("Next Alarm in ..")103 bottomEdgeTitle: i18n.tr("Alarms")
104 bottomEdgePageComponent: AlarmPage {}104 bottomEdgePageComponent: AlarmPage {}
105 }105 }
106 }106 }

Subscribers

People subscribed via source and target branches