Code review comment for lp:~nik90/ubuntu-clock-app/sync-clock-backend

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Nice work as usual, Nekhelesh. A couple of questions:
>
> 121 + text: i18n.tr("Retrieving current location...")
>
> - What's the behaviour if you're offline?
>

Nice question. This is something I specifically tested to ensure that when offline, it notifies the user. So when offline, it will set the string to "Set current location name". The user can click the current location list item to set it manually via the same database used to add a world city. You can test this behaviour on your desktop by clearing the clock database and then going offline.

> - Is GeoIP a backend that could be accessed via Qt Location instead of
> querying http://geoip.ubuntu.com directly?

I will look into this. Popey contact bzoltan for sample code to get location via GPS. You can find his branch at https://code.launchpad.net/~bzoltan/+junk/SystemInfo. However bzoltan while testing it came to the conclusion that it takes a long time to find a gps satellite and retrieve the location coordinates. He said that a bug report needs to be reported on this. I was told all this by Popey, so please contact him regarding gps support. As for using qtlocation for geoIP, the same code used by bzoltan can be used as well for geoIP. However on testing it on my desktop and phone, I found it unreliable to get coordinates via geoIP using qtlocation. Sometime it worked and sometime it didnt.

« Back to merge proposal