Code review comment for lp:~nik90/ubuntu-clock-app/replace-alarmsound-checkbox

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

As for the naming, the page title where we show "add sound from" can accommodate only up to 3 strings beyond which it ellipses due to lack of space (especially when translated).

I like to use "Default alarm sounds" and "Custom alarm sounds".

So the button would also need to be changed to "Add custom alarm sound". While the page title stays "add sound from" due to space constraints.

Does this sound good?

« Back to merge proposal