Code review comment for lp:~nik90/ubuntu-clock-app/remember-clock-mode
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Echoing inline comments:
>
> 1. Could we rename the "clockMode" variable as part of this? It really should
> be something like "isDigital", "digitalMode" or similar since it is a bool
> variable.
>
> 2. Consider loading all the U1db.Documents in the main QML file so they are
> all co-located. Otherwise, in the future finding settings defaults, etc, might
> be difficult.
Fixed in the latest rev