Ubuntu Clock App

Code review comment for lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix

  1. predefined-world-city-translation-fix
  2. Merge into trunk
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

As per the discussion on IRC, I changed the tr() calls to _() calls to make it compatible with gettext(). The only one thing I am not sure about is in http://bazaar.launchpad.net/~ubuntuone-control-tower/unity-scope-click/trunk/view/head:/libclickscope/click/CMakeLists.txt

add_definitions(
  -DGETTEXT_PACKAGE=\"${PROJECT_NAME}\"
  -DGETTEXT_LOCALEDIR=\"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LOCALEDIR}\"
)

I am wondering if I should also include -DGETTEXT_LOCALEDIR=\"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LOCALEDIR}\" as well?

review: Needs Information

« Back to merge proposal