Code review comment for lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix

Revision history for this message
David Planella (dpm) wrote :

The only part I'm not sure of is the tr() method. If I understand it correctly, it's the same upstream translation method, which uses the Qt translation framework.

If that's the case, that won't work with Ubuntu apps, which use gettext. So the code needs to use either Ubuntu's i18n.tr() methods (which call gettext) or gettext functions directly. Here is an example of the click scope using gettext directly:

http://bazaar.launchpad.net/~ubuntuone-control-tower/unity-scope-click/trunk/view/head:/libclickscope/click/click-i18n.h
http://bazaar.launchpad.net/~ubuntuone-control-tower/unity-scope-click/trunk/view/head:/libclickscope/click/highlights.cpp#L127

review: Needs Information

« Back to merge proposal