Hey,
no big mistakes spotted. Seems fine. If you want, for easier readability you could perhaps create a method like:
void addTimeZone(const QString &city, const QString &country, const QString &timeZoneName) { TimeZone tz; tz.cityName = city; tz.timeZone = QTimeZone(timeZoneName); tz.country = tr(country); m_timeZones.append(tz); }
and then call a lot of:
addTimeZone(tr("Anadyr"), tr("Russia"), "Asia/Anadyr"); addTimeZone(tr("Anchorage"), tr("United States"), "America/Anchorage");
« Back to merge proposal
Hey,
no big mistakes spotted. Seems fine. If you want, for easier readability you could perhaps create a method like:
void addTimeZone(const QString &city, const QString &country, const QString &timeZoneName) { timeZoneName) ; .append( tz);
TimeZone tz;
tz.cityName = city;
tz.timeZone = QTimeZone(
tz.country = tr(country);
m_timeZones
}
and then call a lot of:
addTimeZone( tr("Anadyr" ), tr("Russia"), "Asia/Anadyr"); tr("Anchorage" ), tr("United States"), "America/ Anchorage" );
addTimeZone(