Ubuntu Clock App

Code review comment for lp:~nik90/ubuntu-clock-app/play-sound-preview

play-sound-preview
Merge into trunk

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-08-18:

2:03 PM <jhodapp> nik90, yeah I have a pretty good guess of what it is, one sec
2:03 PM <nik90> jhodapp: yay :)
2:03 PM <sergiusens> nik90: is the tone in part of the clock apps directory space
2:04 PM → zoopster joined
2:04 PM <sergiusens> jhodapp: might be the same issue we had with paths?
2:04 PM <jhodapp> sergiusens, exactly
2:04 PM <nik90> sergiusens: directory space? as in does clock have permission to read that folder?
2:05 PM <nik90> jhodapp, sergiusens: Btw the ringtones i am playing are in /usr/share/sounds/ubuntu/ringtones
2:05 PM <jhodapp> nik90, no, as in media-hub won't play that sound for clock-app because of permission policy within media-hub
2:05 PM <nik90> jhodapp: but wasn't it fixed in https://bugs.launchpad.net/media-hub/+bug/1357348
2:05 PM <ubot5> Ubuntu bug 1357348 in mediascanner2 (Ubuntu) "Cannot play sound files due to apparmor permission issue" [Critical,In progress]
2:05 PM <jhodapp> nik90, yep, I can almost guarantee that's the issue now...technically an app is only allowed to play something from its own click *home dir*
2:06 PM <nik90> jhodapp: so how do I fix that in the clock app?
2:06 PM <sergiusens> nik90: click pkgdir com.ubuntu.clock that is
2:07 PM <nik90> sergiusens: ah no we don't ship that folder with the clock app
2:08 PM <jhodapp> nik90, you can check what's going on with media-hub by tailing the log while it tries to play that sound: "tail -f /home/phablet/.cache/upstart/media-hub.log"
2:09 PM — nik90 checks that now
2:09 PM <jhodapp> you should see a line like "client pkgname: com.ubuntu.music
2:09 PM <jhodapp> uri: file:///home/phablet/Music/01 - Gobbledigook.mp3
2:09 PM <jhodapp> Client can access content in ~/Music or ~/Videos""
2:09 PM <jhodapp> nik90, but it should say client not allow access...
2:10 PM <nik90> jhodapp: yup http://paste.ubuntu.com/8079472/
2:11 PM alan_g|lunch → alan_g
2:11 PM <nik90> jhodapp: so what would you advice me to do? Ship that folder internally with the clock app?
2:11 PM <jhodapp> nik90, so please ping jdstrand about this and if he is ok with adding another app exception to the media-hub policy

2:03 PM <jhodapp> nik90, yeah I have a pretty good guess of what it is, one sec
2:03 PM <nik90> jhodapp: yay :)
2:03 PM <sergiusens> nik90: is the tone in part of the clock apps directory space
2:04 PM  → zoopster joined  
2:04 PM <sergiusens> jhodapp: might be the same issue we had with paths?
2:04 PM <jhodapp> sergiusens, exactly
2:04 PM <nik90> sergiusens: directory space? as in does clock have permission to read that folder?
2:05 PM <nik90> jhodapp, sergiusens: Btw the ringtones i am playing are in /usr/share/sounds/ubuntu/ringtones
2:05 PM <jhodapp> nik90, no, as in media-hub won't play that sound for clock-app because of permission policy within media-hub
2:05 PM <nik90> jhodapp: but wasn't it fixed in https://bugs.launchpad.net/media-hub/+bug/1357348
2:05 PM <ubot5> Ubuntu bug 1357348 in mediascanner2 (Ubuntu) "Cannot play sound files due to apparmor permission issue" [Critical,In progress]
2:05 PM <jhodapp> nik90, yep, I can almost guarantee that's the issue now...technically an app is only allowed to play something from its own click *home dir*
2:06 PM <nik90> jhodapp: so how do I fix that in the clock app?
2:06 PM <sergiusens> nik90: click pkgdir com.ubuntu.clock that is
2:07 PM <nik90> sergiusens: ah no we don't ship that folder with the clock app
2:08 PM <jhodapp> nik90, you can check what's going on with media-hub by tailing the log while it tries to play that sound: "tail -f /home/phablet/.cache/upstart/media-hub.log"
2:09 PM — nik90 checks that now
2:09 PM <jhodapp> you should see a line like "client pkgname: com.ubuntu.music
2:09 PM <jhodapp> uri: file:///home/phablet/Music/01 - Gobbledigook.mp3
2:09 PM <jhodapp> Client can access content in ~/Music or ~/Videos""
2:09 PM <jhodapp> nik90, but it should say client not allow access...
2:10 PM <nik90> jhodapp: yup http://paste.ubuntu.com/8079472/
2:11 PM alan_g|lunch → alan_g
2:11 PM <nik90> jhodapp: so what would you advice me to do? Ship that folder internally with the clock app?
2:11 PM <jhodapp> nik90, so please ping jdstrand about this and if he is ok with adding another app exception to the media-hub policy

« Back to merge proposal