Code review comment for lp:~nik90/ubuntu-clock-app/new-headers-api

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> This looks good. Could we still remove the custom back action but not
> introduce the Trusty regression? If you have a reason to jump forward to use
> the "head" property that is also fine.

I am afraid we can't :/. The design shown at https://docs.google.com/presentation/d/1Kkl7xT8BYo9mT8i3IXh6rPrDlNg6cBxTajahlRYIGlI/edit#slide=id.g18883f09d_2108 requires the back button to look like a close button and for that we need to have a custom back action. I could request the designers to consider using the default back button, but I notice that when adding a new contact in the address book, it also uses a custom back button to show the close button. So I think we should stick to the design specs.

The Trusty support is being dropped since when working on the next main feature which is the world clocks, the add city page will use the new header search mode which requires the new header API. So we break Trusty compatibility either now or a few days later.

I say we go ahead with this, but will wait for your approval before merging.

« Back to merge proposal