Code review comment for lp:~nik90/ubuntu-clock-app/more-stopwatch-tests

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

The aforementioned error is no longer an issue, however RE: IRC, the test_add_online_world_city isn't testing online cities like you think :- )

I would also add an assert to ensure the stopwatch time moves in test_create_lap, even if you sleep. This will prevent timing issues where you try and hit a lap with no time elapsed :-)

review: Needs Fixing

« Back to merge proposal