Code review comment for lp:~nik90/ubuntu-clock-app/implement-location-finding

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> If I launch it from QTC (instead of creating a click package) works.
>
> Tests work as expected, but if I launch the app with position deactivate from
> the indicator it says "Location Service Error" as expected, but when I turn on
> position service from indicator the app doesn't try to update location, but
> stays stucked on "Location Service Error"

Yeah that's because the clock app you will need to restart the app to update the location. Currently the location is updated only on 2 conditions,

1. On application startup
2. If the clock app is brought to the foreground 30 mins later

It does not continuously keep searching for the user location since that would be bad for the battery. So in your situation where you disabled the position service and then renabled it, the clock app does not get a signal that you turned it on. So you will need to restart the clock app.

A better way of fixing your situation would be to add a refresh button which the user can press to search for the location, but we are way past UI freezes to get this done.

« Back to merge proposal