Merge lp:~nik90/ubuntu-clock-app/fix-alarm-list-refresh into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 362
Merged at revision: 359
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-alarm-list-refresh
Merge into: lp:ubuntu-clock-app
Diff against target: 51 lines (+5/-5)
3 files modified
app/alarm/AlarmList.qml (+1/-1)
app/alarm/EditAlarmPage.qml (+3/-4)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-alarm-list-refresh
Reviewer Review Type Date Requested Status
Zsombor Egri (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+269047@code.launchpad.net

Commit message

Refresh alarmModel when the alarm being edited is saved to ensure that the listview shows updated labels.

Description of the change

Refresh alarmModel when the alarm being edited is saved to ensure that the listview shows updated labels.

To post a comment you must log in.
361. By Nekhelesh Ramananthan

Minor changelog typo fixed

362. By Nekhelesh Ramananthan

Revert making variable readonly

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks good, and right way to refresh the list.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/alarm/AlarmList.qml'
--- app/alarm/AlarmList.qml 2015-08-12 14:24:08 +0000
+++ app/alarm/AlarmList.qml 2015-08-25 11:39:26 +0000
@@ -71,7 +71,7 @@
71 if (selectMode) {71 if (selectMode) {
72 selected = !selected72 selected = !selected
73 } else {73 } else {
74 pageStack.push(Qt.resolvedUrl("EditAlarmPage.qml"), {isNewAlarm: false, tempAlarm: model})74 pageStack.push(Qt.resolvedUrl("EditAlarmPage.qml"), {isNewAlarm: false, tempAlarm: model, alarmModel: alarmModel})
75 }75 }
76 }76 }
7777
7878
=== modified file 'app/alarm/EditAlarmPage.qml'
--- app/alarm/EditAlarmPage.qml 2015-08-24 16:30:33 +0000
+++ app/alarm/EditAlarmPage.qml 2015-08-25 11:39:26 +0000
@@ -28,12 +28,10 @@
28 id: _addAlarmPage28 id: _addAlarmPage
29 objectName: "AddAlarmPage"29 objectName: "AddAlarmPage"
3030
31 // Property to determine if this is a new/saved alarm31 property var alarmModel
32 property var tempAlarm
32 property bool isNewAlarm: true33 property bool isNewAlarm: true
3334
34 // Temporary alarm used to read saved alarm and modify them
35 property var tempAlarm
36
37 title: isNewAlarm ? i18n.tr("New alarm") : i18n.tr("Edit alarm")35 title: isNewAlarm ? i18n.tr("New alarm") : i18n.tr("Edit alarm")
38 visible: false36 visible: false
3937
@@ -112,6 +110,7 @@
112110
113 if(validateAlarm(tempAlarm)) {111 if(validateAlarm(tempAlarm)) {
114 pageStack.pop()112 pageStack.pop()
113 alarmModel.refresh()
115 }114 }
116 }115 }
117116
118117
=== modified file 'debian/changelog'
--- debian/changelog 2015-08-23 13:25:17 +0000
+++ debian/changelog 2015-08-25 11:39:26 +0000
@@ -28,6 +28,7 @@
28 * Fixed alarm sound preview not playing when pressing on the checkbox (LP: #1487690)28 * Fixed alarm sound preview not playing when pressing on the checkbox (LP: #1487690)
29 * Fixed edited alarm not being saveable if at any point of editing the alarm29 * Fixed edited alarm not being saveable if at any point of editing the alarm
30 clock app loses focus (LP: #1487789)30 clock app loses focus (LP: #1487789)
31 * Fixed edited alarms when saved not updating the alarms listview (LP: #1488439)
3132
32 [Victor Thompson]33 [Victor Thompson]
33 * Show all README files in QtCreator 34 * Show all README files in QtCreator

Subscribers

People subscribed via source and target branches