Code review comment for lp:~nik90/ubuntu-clock-app/edit-alarm-feature

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Nik, could you address this:
>
> > In my opinion there should not be a default "label" for a new alarm. The
> user should simply be
> > required to add a label. No real person makes an alarm and lets it be
> labeled "Alarm #1".

I changed the default "label" for new alarms to just "Alarm" as specified in visual mock up shown to us at Malta https://docs.google.com/presentation/d/1JvDyhsW17d1-Mz8OY1YMBKwfRI2z9qgyRjbujEsxEMk/edit#slide=id.g34303b1ce_2_11.

I compared our solution with iOS and Android and noticed they do it as well.

The reason I don't want to keep it empty is because it increases the amount of steps the user needs to do before saving an alarm. As of now, the user needs to only adjust the time to create the alarm. Every other field has a sensible default value defined.

« Back to merge proposal