Code review comment for lp:~nik90/ubuntu-clock-app/edit-alarm-feature

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Just a note that browsing the ringtones does not work on Trusty, conceivably
> because /usr/share/sounds/ubuntu/ringtones does not exist. This defaults to
> the current directory in this case. Perhaps you need some sort of fall back to
> show nothing when this directory does not exist. Otherwise the user can select
> random files in the current directory. Likewise, filtering on ogg and mp3
> files might be a good idea.

From Ubuntu 14.04 onwards, you need a specific package to get the ubuntu touch ringtones on the desktop. I am unable to remember what that package is. I have it installed on my 14.04 setup and I can browse the ringtones properly. Once we get the packaging fixed, that package will be added as a dependency for the clock app. So this shouldn't be an issue then.

I am not sure how to detect the existance of a folder. The QML FolderListModel http://qt-project.org/doc/qt-5/qml-qt-labs-folderlistmodel-folderlistmodel.html does not provide to check that.

« Back to merge proposal