Merge lp:~nik90/ubuntu-clock-app/diff-clock-markers into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 24
Merged at revision: 23
Proposed branch: lp:~nik90/ubuntu-clock-app/diff-clock-markers
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 34 lines (+14/-3)
1 file modified
common/AnalogClockFace.qml (+14/-3)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/diff-clock-markers
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Juha Ristolainen Pending
Nick Leppänen Larsson Pending
Review via email: mp+157145@code.launchpad.net

Commit message

Description of the change

This MP changes the colour of the clock markers around 3,6,9 and 12 mark for better readability.

To post a comment you must log in.
23. By Nekhelesh Ramananthan

Merge from master

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
24. By Nekhelesh Ramananthan

Merge from master

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Trivial change. Got approval from design using the G+ Hangout. Hence approving this MP.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/AnalogClockFace.qml'
--- common/AnalogClockFace.qml 2013-04-05 21:27:48 +0000
+++ common/AnalogClockFace.qml 2013-04-09 10:19:26 +0000
@@ -20,6 +20,7 @@
2020
21import QtQuick 2.021import QtQuick 2.0
22import Ubuntu.Components 0.122import Ubuntu.Components 0.1
23import "../common/Constants.js" as Constants
2324
24AnalogFaceBase {25AnalogFaceBase {
25 id: clockRoot26 id: clockRoot
@@ -75,9 +76,19 @@
75 }76 }
7677
77 Repeater {78 Repeater {
78 model: 1279 model: ["1", "2", "4", "5", "7", "8", "10", "11"]
79 delegate: AnalogClockMarker {80 delegate: AnalogClockMarker {
80 number: index81 number: modelData
82 size:0.7
83 }
84 }
85
86 Repeater {
87 model: ["3", "6", "9", "12"]
88 delegate: AnalogClockMarker {
89 number: modelData
90 size: 1
91 color: Constants.pitchBlack
81 }92 }
82 }93 }
83}94}

Subscribers

People subscribed via source and target branches