Code review comment for lp:~nik90/ubuntu-clock-app/dialer-transition

Revision history for this message
Michael Zanetti (mzanetti) wrote :

18 + // The range of the analogue clock is 0-60 while the alarm hours should be between 00-23. Hence the factor 23/60
19 + alarmTime.setHours(Math.round(addAlarmFace.hours*23/60), Math.round(addAlarmFace.minutes), 0)

Could it make sense to create a function hoursToCirclePosition() instead of copy pasting this all over the place?

===

1079 + model: ["0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23"]

model: 23
should be enough

===

803 + // Property to help with the naming of the clock hands for autopilot purposes
804 + property string objectBase: "Default"

I think it would be cleaner to drop this and change the autopilot tests to do a 2 step search. eg.

select_single(objectName="clockPage").select_single(objectName="hourHandAlarm")

« Back to merge proposal