Merge lp:~nik90/ubuntu-clock-app/delay-alarm-model-startup into lp:ubuntu-clock-app
Proposed by
Nekhelesh Ramananthan
Status: | Merged |
---|---|
Approved by: | Nekhelesh Ramananthan |
Approved revision: | 148 |
Merged at revision: | 142 |
Proposed branch: | lp:~nik90/ubuntu-clock-app/delay-alarm-model-startup |
Merge into: | lp:ubuntu-clock-app |
Diff against target: |
345 lines (+111/-42) 13 files modified
app/alarm/AlarmModelComponent.qml (+25/-0) app/alarm/AlarmPage.qml (+1/-3) app/alarm/EditAlarmPage.qml (+1/-0) app/clock/ClockPage.qml (+1/-1) app/clock/MainClock.qml (+18/-0) app/components/AnalogMode.qml (+16/-6) app/components/Background.qml (+1/-0) app/components/DigitalMode.qml (+32/-23) app/ubuntu-clock-app.qml (+7/-6) app/upstreamcomponents/PageWithBottomEdge.qml (+5/-0) debian/changelog (+1/-0) tests/autopilot/ubuntu_clock_app/emulators.py (+3/-2) tests/unit/tst_alarm.qml (+0/-1) |
To merge this branch: | bzr merge lp:~nik90/ubuntu-clock-app/delay-alarm-model-startup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Riccardo Padovani | Approve | ||
Ubuntu Clock Developers | Pending | ||
Review via email: mp+238031@code.launchpad.net |
Commit message
Improve startup time by delaying the loading the alarm model at app startup.
Description of the change
Improve startup time by delaying the loading the alarm model at app startup.
The improvements reduces the start time by 647.8 ms (~23.73%)! There is still room for improvement, but I will experiment on that in my next MP.
@Riccardo, this is the exact same MP that you previously approved at https:/
To post a comment you must log in.
FAILED: Continuous integration, rev:142 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/549/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic- python3/ 865/console
http://
Executed test runs:
FAILURE: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/549/ rebuild
http://