Code review comment for lp:~nik90/ubuntu-clock-app/correct-time-locale
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
>3. Wouldn't it still be possible to parse the time separator and have it displayed in a different >color?
I am unable to think of a logic which will work across all locales. Previously we used the colon ":" to do the splitting which fails in other locales. May be we can come up with a regex expression which doesn't depend on the time separator.
Somehow I feel this solution in the MP is more fail proof due to its simplicity while we stand on the shoulders of Qt locale(). Surprisingly Qt.locale() does not have a property for time separator. Otherwise I would have used that.