Merge lp:~nik90/ubuntu-clock-app/change-x-icon into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 102
Merged at revision: 102
Proposed branch: lp:~nik90/ubuntu-clock-app/change-x-icon
Merge into: lp:ubuntu-clock-app
Diff against target: 40 lines (+10/-19)
1 file modified
app/alarm/EditAlarmPage.qml (+10/-19)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/change-x-icon
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Mihir Soni (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+234850@code.launchpad.net

Commit message

Replace custom back icon X with the general "<" chevron back button as requested by design.

Description of the change

Replace custom back icon X with the general "<" chevron back button as requested by design.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks great.
Thanks for MR.

review: Approve
Revision history for this message
Mihir Soni (mihirsoni) wrote :

lgtm !!

Thanks for MR.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/alarm/EditAlarmPage.qml'
--- app/alarm/EditAlarmPage.qml 2014-09-08 22:31:11 +0000
+++ app/alarm/EditAlarmPage.qml 2014-09-16 17:03:08 +0000
@@ -40,26 +40,17 @@
40 title: isNewAlarm ? i18n.tr("New alarm") : i18n.tr("Edit alarm")40 title: isNewAlarm ? i18n.tr("New alarm") : i18n.tr("Edit alarm")
41 visible: false41 visible: false
4242
43 head {43 head.actions: Action {
44 backAction: Action {44 id: saveAlarmButton
45 iconName: "close"45 iconName: "ok"
46 onTriggered: {46 objectName: "saveAlarmAction"
47 mainStack.pop()47 text: i18n.tr("Alarm")
48 onTriggered: {
49 if(isNewAlarm) {
50 saveNewAlarm()
48 }51 }
49 }52 else {
5053 updateAlarm()
51 actions: Action {
52 id: saveAlarmButton
53 iconName: "ok"
54 objectName: "saveAlarmAction"
55 text: i18n.tr("Alarm")
56 onTriggered: {
57 if(isNewAlarm) {
58 saveNewAlarm()
59 }
60 else {
61 updateAlarm()
62 }
63 }54 }
64 }55 }
65 }56 }

Subscribers

People subscribed via source and target branches