Code review comment for lp:~nik90/ubuntu-clock-app/change-timer-logic
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> please avoid to create extra ".js" files try to keep everything on QML if is
> not possible use the commom file, this way we can re-use the code for other
> pages.
I didn't create a new .js file. In fact I made the function function getstringTimer() smaller by utilizing function ssToTime(). The function ssToTime() is required by both analogTimer.qml and TimerPage.qml hence its place in the .js file.