Merge lp:~nik90/ubuntu-clock-app/change-countryname-position into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 187
Merged at revision: 187
Proposed branch: lp:~nik90/ubuntu-clock-app/change-countryname-position
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 25 lines (+10/-2)
1 file modified
clock/WorldClock.qml (+10/-2)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/change-countryname-position
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+184389@code.launchpad.net

Commit message

Reduces the country name font size and positions it below the city name to prevent overflowing text.

Description of the change

This branch changes the design of the cities results list by reducing the font size of the state, country names and also positioning them beneath the city names. This prevents any results being too long that it goes off screen. The implementation is as per the new design which can be seen at https://mail-attachment.googleusercontent.com/attachment/u/0/?ui=2&ik=4f90c10d21&view=att&th=140eebe8c2fcc5e8&attid=0.1&disp=inline&realattid=f_hl84vo4e0&safe=1&zw&saduie=AG9B_P8X6flBM44Q7TV0yPjSPEw3&sadet=1378499656117&sads=JseR2_3XGhSwN2Pdg33HFc3juCE&sadssc=1.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'clock/WorldClock.qml'
--- clock/WorldClock.qml 2013-09-06 20:22:31 +0000
+++ clock/WorldClock.qml 2013-09-06 21:01:12 +0000
@@ -164,11 +164,19 @@
164164
165 delegate: ListItem.Standard {165 delegate: ListItem.Standard {
166 Label {166 Label {
167 text: searchCityModel.status == XmlListModel.Ready ? (adminName ? (city + ", " + adminName + ", " + country) : (city + ", " + country)) : i18n.tr("Loading");167 id: cityDelegate
168 anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }168 text: city
169 anchors { top: parent.top; topMargin: units.gu(0.5); left: parent.left; leftMargin: units.gu(3) }
169 color: Theme.palette.normal.baseText170 color: Theme.palette.normal.baseText
170 fontSize: "large"171 fontSize: "large"
171 }172 }
173 Label {
174 text: adminName ? adminName + ", " + country : country
175 anchors { top: cityDelegate.bottom; bottom: parent.bottom; left: parent.left; leftMargin: units.gu(3) }
176 color: Theme.palette.normal.baseText
177 fontSize: "small"
178 }
179
172 selected: worldList.currentIndex == index;180 selected: worldList.currentIndex == index;
173181
174 onClicked: {182 onClicked: {

Subscribers

People subscribed via source and target branches